[
https://issues.apache.org/jira/browse/NUTCH-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118413#comment-18118413
]
Hudson commented on NUTCH-3214:
-------------------------------
SUCCESS: Integrated in Jenkins build Nutch » Nutch-trunk #272 (See
[https://ci-builds.apache.org/job/Nutch/job/Nutch-trunk/272/])
NUTCH-3214 Remove Javadoc author tags so Apache Yetus author check passes
(#970) (github:
[https://github.com/apache/nutch/commit/81c25c16eded2e7799b0c4f8eb0a66421e782f8f])
* (edit) src/java/org/apache/nutch/plugin/ExtensionPoint.java
* (edit)
src/plugin/urlnormalizer-pass/src/java/org/apache/nutch/net/urlnormalizer/pass/PassURLNormalizer.java
* (edit) src/java/org/apache/nutch/crawl/CrawlDbFilter.java
* (edit) src/java/org/apache/nutch/crawl/CrawlDbMerger.java
* (edit)
src/plugin/index-basic/src/test/org/apache/nutch/indexer/basic/TestBasicIndexingFilter.java
* (edit) src/test/org/apache/nutch/parse/TestParserFactory.java
* (edit) src/java/org/apache/nutch/crawl/AbstractFetchSchedule.java
* (edit)
src/plugin/language-identifier/src/java/org/apache/nutch/analysis/lang/LanguageIndexingFilter.java
* (edit)
src/plugin/microformats-reltag/src/java/org/apache/nutch/microformats/reltag/RelTagIndexingFilter.java
* (edit) src/java/org/apache/nutch/metadata/DublinCore.java
* (edit) src/java/org/apache/nutch/crawl/FetchSchedule.java
* (edit)
src/plugin/protocol-file/src/test/org/apache/nutch/protocol/file/TestProtocolFile.java
* (edit) src/java/org/apache/nutch/metadata/Feed.java
* (edit) src/java/org/apache/nutch/plugin/PluginRuntimeException.java
* (edit)
src/plugin/index-replace/src/java/org/apache/nutch/indexer/replace/FieldReplacer.java
* (edit)
src/plugin/protocol-httpclient/src/java/org/apache/nutch/protocol/httpclient/Http.java
* (edit)
src/plugin/protocol-httpclient/src/java/org/apache/nutch/protocol/httpclient/HttpAuthentication.java
* (edit)
src/plugin/protocol-ftp/src/java/org/apache/nutch/protocol/ftp/FtpException.java
* (edit)
src/plugin/urlfilter-prefix/src/test/org/apache/nutch/urlfilter/prefix/TestPrefixURLFilter.java
* (edit) src/java/org/apache/nutch/crawl/SignatureFactory.java
* (edit) src/java/org/apache/nutch/parse/ParsePluginsReader.java
* (edit) src/test/org/apache/nutch/crawl/TestCrawlDbFilter.java
* (edit)
src/plugin/index-static/src/test/org/apache/nutch/indexer/staticfield/TestStaticFieldIndexerTest.java
* (edit)
src/plugin/protocol-httpclient/src/java/org/apache/nutch/protocol/httpclient/HttpAuthenticationFactory.java
* (edit) src/java/org/apache/nutch/parse/ParseStatus.java
* (edit) src/java/org/apache/nutch/scoring/ScoringFilterException.java
* (edit) src/java/org/apache/nutch/metadata/Nutch.java
* (edit) src/java/org/apache/nutch/net/URLNormalizers.java
* (edit) src/java/org/apache/nutch/plugin/URLStreamHandlerFactory.java
* (edit) src/test/org/apache/nutch/metadata/TestSpellCheckedMetadata.java
* (edit) src/java/org/apache/nutch/crawl/MimeAdaptiveFetchSchedule.java
* (edit) src/java/org/apache/nutch/metadata/MetaWrapper.java
* (edit) src/java/org/apache/nutch/scoring/ScoringFilter.java
* (edit) src/java/org/apache/nutch/crawl/LinkDbFilter.java
* (edit)
src/plugin/lib-regex-filter/src/java/org/apache/nutch/urlfilter/api/RegexRule.java
* (edit) src/java/org/apache/nutch/plugin/Plugin.java
* (edit)
src/plugin/protocol-httpclient/src/java/org/apache/nutch/protocol/httpclient/HttpResponse.java
* (edit)
src/plugin/urlfilter-regex/src/test/org/apache/nutch/urlfilter/regex/TestRegexURLFilter.java
* (edit)
src/plugin/urlfilter-validator/src/test/org/apache/nutch/urlfilter/validator/TestUrlValidator.java
* (edit) src/java/org/apache/nutch/metadata/CreativeCommons.java
* (edit) src/java/org/apache/nutch/plugin/Pluggable.java
* (edit)
src/plugin/index-anchor/src/test/org/apache/nutch/indexer/anchor/TestAnchorIndexingFilter.java
* (edit)
src/plugin/index-more/src/java/org/apache/nutch/indexer/more/MoreIndexingFilter.java
* (edit) src/test/org/apache/nutch/parse/TestOutlinkExtractor.java
* (edit) src/test/org/apache/nutch/plugin/SimpleTestPlugin.java
* (edit) src/java/org/apache/nutch/util/LockUtil.java
* (edit)
src/plugin/protocol-ftp/src/java/org/apache/nutch/protocol/ftp/PrintCommandListener.java
* (edit)
src/plugin/protocol-httpclient/src/java/org/apache/nutch/protocol/httpclient/HttpAuthenticationException.java
* (edit) src/java/org/apache/nutch/plugin/CircularDependencyException.java
* (edit)
src/plugin/feed/src/java/org/apache/nutch/indexer/feed/FeedIndexingFilter.java
* (edit)
src/plugin/parse-zip/src/test/org/apache/nutch/parse/zip/TestZipParser.java
* (edit) src/java/org/apache/nutch/segment/SegmentPart.java
* (edit) src/java/org/apache/nutch/plugin/MissingDependencyException.java
* (edit) src/test/org/apache/nutch/plugin/HelloWorldExtension.java
* (edit) src/java/org/apache/nutch/parse/ParsePluginList.java
* (edit) src/java/org/apache/nutch/tools/CommonCrawlFormat.java
* (edit)
src/plugin/index-replace/src/java/org/apache/nutch/indexer/replace/ReplaceIndexer.java
* (edit) src/java/org/apache/nutch/plugin/PluginManifestParser.java
* (edit) src/java/org/apache/nutch/crawl/LinkDbMerger.java
* (edit) src/java/org/apache/nutch/net/URLFilterChecker.java
* (edit) src/java/org/apache/nutch/parse/OutlinkExtractor.java
* (edit)
src/plugin/index-arbitrary/src/test/org/apache/nutch/indexer/arbitrary/TestArbitraryIndexingFilter.java
* (edit)
src/plugin/index-replace/src/test/org/apache/nutch/indexer/replace/TestIndexReplace.java
* (edit)
src/plugin/urlfilter-automaton/src/test/org/apache/nutch/urlfilter/automaton/TestAutomatonURLFilter.java
* (edit) src/test/org/apache/nutch/plugin/ITestExtension.java
* (edit)
src/plugin/feed/src/test/org/apache/nutch/parse/feed/TestFeedParser.java
* (edit)
src/plugin/protocol-ftp/src/java/org/apache/nutch/protocol/ftp/FtpExceptionBadSystResponse.java
* (edit)
src/plugin/scoring-opic/src/java/org/apache/nutch/scoring/opic/OPICScoringFilter.java
* (edit) src/java/org/apache/nutch/crawl/DefaultFetchSchedule.java
* (edit) src/java/org/apache/nutch/scoring/ScoringFilters.java
* (edit) src/java/org/apache/nutch/protocol/ProtocolOutput.java
* (edit)
src/plugin/parse-ext/src/test/org/apache/nutch/parse/ext/TestExtParser.java
* (edit) src/java/org/apache/nutch/protocol/ProtocolStatus.java
* (edit)
src/plugin/protocol-ftp/src/java/org/apache/nutch/protocol/ftp/FtpExceptionCanNotHaveDataConnection.java
* (edit)
src/plugin/protocol-ftp/src/java/org/apache/nutch/protocol/ftp/FtpExceptionControlClosedByForcedDataClose.java
* (edit)
src/plugin/protocol-ftp/src/java/org/apache/nutch/protocol/ftp/FtpExceptionUnknownForcedDataClose.java
* (edit)
src/plugin/parse-zip/src/java/org/apache/nutch/parse/zip/ZipTextExtractor.java
* (edit)
src/plugin/urlfilter-suffix/src/test/org/apache/nutch/urlfilter/suffix/TestSuffixURLFilter.java
> Remove Javadoc author tags so Apache Yetus author check passes
> --------------------------------------------------------------
>
> Key: NUTCH-3214
> URL: https://issues.apache.org/jira/browse/NUTCH-3214
> Project: Nutch
> Issue Type: Improvement
> Components: ci/cd
> Affects Versions: 1.23
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Trivial
> Fix For: 1.24
>
>
> Apache Yetus test-patch is voting -1 on the @author plugin because Nutch
> still has Javadoc @author tags in Java sources.
> The GitHub workflow (.github/workflows/yetus.yml) runs
> apache/[email protected] with plugins: all (minus jira, gitlab,
> unit, compile). The author plugin fails when it finds @author in the patch
> or, on master, in the tree. Typical vote text:
> _*-1 @author The patch appears to contain N @author tags which the
> community has agreed to not allow in code contributions.*_
> This matches long-standing ASF practice: author tags are discouraged because
> they confuse ownership (ASF copyright, not per-file authors) and committer
> protection. Authorship belongs in git history and release notes, not in
> source files. Same cleanup as Hadoop (HADOOP-1147 / HADOOP-6031) and other
> ASF projects.
> Proposed change
> - Strip @author (and only those) Javadoc lines from Nutch-owned Java sources.
> - Do not rewrite surrounding comments beyond dropping the tags.
> - Do not add Yetus author-ignore-list entries for these files; the tags
> should go away rather than be excepted.
> - No runtime or API change.
> Authors remain visible via git log / git blame. Do not add names to
> CHANGES.md as part of this cleanup.
> Acceptance
> - No @author tags remain in Nutch Java sources.
> - Apache Yetus author check votes +1 on a follow-up PR and on master.
> This is mechanical Javadoc cleanup so Yetus CI can go green; it is not a
> functional bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
