-1 It is Not inline with long term goal and a violation of the Inviolable o Expediency is not a justification for violating the coding standard.
-----Original Message----- From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com] Sent: Saturday, March 07, 2020 10:11 AM To: dev@nuttx.apache.org Subject: Should we relax precheck a little bit? Hi all, The precheck ensure the whole file content comform to the coding style, this strategy has several problems: 1.Many source file in mainline already violate the coding style 2.nxstyle frequently generate the false alarm in the current stage How about we let precheck just ensure the modified line don't violate the coding standards? I am asking this question because: 1.The change in PR 471 has a very good shape: https://github.com/apache/incubator-nuttx/pull/471/files but the whole file precheck complain there are many errors: https://github.com/apache/incubator-nuttx/pull/471/checks?check_run_id=492244725 It is unfair to require the contributor to fix the issue not made by them. 2.Most PR will fail at precheck stage due to item 1 and then block the more important build test. Thanks Xiang
