Hi Greg,
On 6/24/20, Gregory Nutt <spudan...@gmail.com> wrote:
>
> Changing the default is not the problem. The problem is when the
> default configuration value is changed, the all configurations effected
> by that change in the default setting should be updated so that they are
> not effected. That is, so the net result is no change. That was not
> done and that is an error.
>
> In this case, the NSH 'date' command used to default to 'disabled'
> UNLESS an RTC was supported, then the default is 'enabled'. There error
> is, that that the 'date' command should have also been explicitly
> disabled in ALL NSH configurations that do not have the RTC enabled.
>
> That has a negative user impact and would think that correcting that is
> more important than meeting an artificial release deadline.
>
>> The TLS changes are harder for me to judge and the netdb change I
>> think just changes ram usage.
>
> I don't believe that the TLS changes added any significant size. It
> replaces one small, simple implementation with another small, simple
> implementation. It is hard to envision how this would cause any
> noticeable size increase. But perhaps.
>
> Another thing that I noted in Alin's configuration comparison is that
> the variadic version of the ioctl() interface is no longer optional.
> That I expect will add a couple hundred bytes to the size of every
> configuration.
>
> The main cause of the size increase is the default 'date' command
> setting. Not only does that enabled the NSH data command but draws all
> of the time computation logic into the build. This will probably break
> many of the more resource constrained configurations.
>
Currently it appears to depend on !CONFIG_DEFAULT_SMALL only:
config NSH_DISABLE_DATE
bool "Disable date"
default y if DEFAULT_SMALL
default n if !DEFAULT_SMALL
Shouldn't it depends on !CONFIG_DEFAULT_SMALL && CONFIG_RTC ?
BR,
Alan
