On 2026-02-04 18:39, Tomek CEDRO wrote:
As I can see Xiang is still closing the PRs from Xiaomi. Looks like decision was already made. We are always confronted with existing post factum situation with nothing to say. My only choice is to accept that so I do.
Well, one person is closing PRs from Xiaomi (I assume that person is a Xiaomi employee) but someone else posted in this thread that working with upstream is important for them. Maybe not the company as a whole isn't on the same page with regards to this?
That would hurt all other contributions because one big company with unlimited resources drained all of our free community resources.. and something does not add up here because if their changes are always so well tested before then why they don't perfectly build at first run on our upstream??
This is something I was wondering about as well. This thread describes how Xiaomi does testing and it sounds very reasonable. The question then arises - what exactly are they testing? Is it upstream or their product(s) with code base diverged from upstream? If it is the latter, then I can understand that they can be offended by people doubting their testing process but at the same time this process is not testing the upstream.
And if - as few people mentioned in this thread and in the linked GitHub PRs - these tested changes break stuff for other people, then clearly the testing process - while being good for Xiaomi code - is insufficient for upstream. In which case the answer to "how the changes in the PR were tested" would actually be (from upstream's point of view) "they were not".
Meanwhile, the solution seems to be simple - do at least the same thing that CI on GH does internally. (I am quite sure someone with appropriate access would gladly provide the tools needed for that.)
Just to be sure - all of this applies only in case that Xiaomi's internal testing only covers their diverged code base.
Well, this proves many problems that NuttX community raised before, but from my perspective Sebastien is not the problem here, quite the opposite. Maybe the community split is unavoidable and will do some good for everyone the sooner the better. That concludes my position.
I won't be playing a judge between those two parties but this is not the first time I saw (here and/or Github) someone calling someone else toxic etc. while being even more so in the process...
