casaroli commented on code in PR #10:
URL: https://github.com/apache/nuttx-ntfc/pull/10#discussion_r3657643991
##########
src/ntfc/device/sim.py:
##########
@@ -49,7 +49,9 @@ def _start_impl(self) -> None:
uptime = self._conf.uptime
# open host-based emulation
- self.host_open(cmd, uptime)
+ child = self.host_open(cmd, uptime)
+ if self._conf.line_buffered:
+ child.delaybeforesend = 0
Review Comment:
Can we do the qemu interaction later in a followup PR?
Do we currently have qemu testing in the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]