raiden00pl commented on code in PR #10:
URL: https://github.com/apache/nuttx-ntfc/pull/10#discussion_r3657834445
##########
src/ntfc/device/sim.py:
##########
@@ -49,7 +49,9 @@ def _start_impl(self) -> None:
uptime = self._conf.uptime
# open host-based emulation
- self.host_open(cmd, uptime)
+ child = self.host_open(cmd, uptime)
+ if self._conf.line_buffered:
+ child.delaybeforesend = 0
Review Comment:
these are qemu targets:
```
./boards/arm64/fvp-v8r/fvp-armv8r/configs/citest
./boards/arm64/qemu/qemu-armv8a/configs/citest
./boards/risc-v/qemu-rv/rv-virt/configs/citest
./boards/arm/imx6/sabre-6quad/configs/citest
```
your change won't work when the device crashes and is reopened, so it's
better to move the logic to `host_open()` now. This feature is disabled by
default, so it doesn't cause problems for current QEMU targets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
