Guido,
Why not, please create a jira issue an attach your patch. Please if someone see
a problem fell free to express yourself.
Thanks
Jacques
----- Original Message -----
From: "Guido Amarilla" <[EMAIL PROTECTED]>
To: <dev@ofbiz.apache.org>
Sent: Saturday, January 13, 2007 4:47 PM
Subject: Re: Quote screens issues
> 2007/1/13, Jacques Le Roux <[EMAIL PROTECTED]>:
> > Guido,
> >
> > From: "Guido Amarilla" <[EMAIL PROTECTED]>
> > > I just wanted to confirm that these are acceptable issues, before
> > > creating them in JIRA:
> > >
> > > 1) In Quote edit screens the title is made by combining Quote ID +
> > > Quote Description. As Description is a multiline text, and could be
> > > long, this really should be Quote Id + Quote Name. Isn´t it?
> >
> > Description is *not* a multiline text (or I don't know how to put
> > multi-lines in, I did not look at code yet). So it seems not a
> > problem to me.
> >
>
> Yes, it`s true. it is not a multiline text. I needed some field to put
> a description for the quote. I understand that a description is a
> field that I can write longer sentences to describe the quote. If that
> is true, then that should be changed to show the quote name as a
> header, and this is a proposed patch.
>
> Index: ofbiz/trunk/applications/order/widget/ordermgr/CommonScreens.xml
> ===================================================================
> --- ofbiz/trunk/applications/order/widget/ordermgr/CommonScreens.xml (revision
> 495129)
> +++ ofbiz/trunk/applications/order/widget/ordermgr/CommonScreens.xml (working
> copy)
> @@ -68,7 +68,7 @@
> <html><html-template
> location="component://order/webapp/ordermgr/quote/QuoteTabBar.ftl"/></html>
> </platform-specific>
> <container>
> - <label
> style="head1">[${uiLabelMap.CommonId}:${quote.quoteId}]
> ${quote.description}</label>
> + <label
> style="head1">[${uiLabelMap.CommonId}:${quote.quoteId}]
> ${quote.quoteName}</label>
> </container>
>
> <decorator-section-include name="body"/>
> @@ -99,7 +99,7 @@
> <html><html-template
> location="component://order/webapp/ordermgr/quote/QuoteTabBar.ftl"/></html>
> </platform-specific>
> <container>
> - <label
> style="head1">[${uiLabelMap.CommonId}:${quote.quoteId}]
> ${quote.description}</label>
> + <label
> style="head1">[${uiLabelMap.CommonId}:${quote.quoteId}]
> ${quote.quoteName}</label>
> </container>
>
> <decorator-section-include name="body"/>
>
>
>
>
>
> > > 2) I need to add some "conditions" to the quote in the PDF report, to
> > > send it to the customer, like "VAT is included in prices" or "Travel
> > > Expenses not included". I didn´t find any specialized field so I added
> > > attributes to do it. Is it right to do this way? I also noticed that
> > > these attributes are not printed in the PDF report. Should them be
> > > included in the template creating an issue for this or should I
> > > customize it just for myself?
> >
> > You may submit a patch in Jira and we will see, don't you think so ?
>
> I think so.
>
>
> >
> > Jacques
> >
> > > Thanks
> > > --
> > > Guido Amarilla
> > > Córdoba, Argentina
> >
> >
>
>
> --
> Guido Amarilla
