[ 
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504346
 ] 

Adrian Crum commented on OFBIZ-1041:
------------------------------------

Maybe something is getting lost in the translation. It seems to me that the 
attached patches ENFORCE David's  point.

For example, the line in 
applications/party/webapp/partymgr/party/editcontactmech.ftl -

<option>${(mechMap.partyContactMech.allowSolicitation)?if_exists}</option>

wouldn't make sense to someone who doesn't speak English because the raw data 
(Y/N) is being displayed.

The patch fixes this by using the raw data (Y/N) to look up the correct UI 
label (CommonY/CommonN) -

        <#if (mechMap.partyContactMech.allowSolicitation)?exists >
          <option><#if (mechMap.partyContactMech.allowSolicitation?default("") 
== "Y")>${uiLabelMap.CommonY}</#if>
                  <#if (mechMap.partyContactMech.allowSolicitation?default("") 
== "N")>${uiLabelMap.CommonN}</#if>
          </option>
        </#if>


> various values in allowSolicitation variable  break some screens
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1041
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1041
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Krzysztof Podejma
>            Assignee: Si Chen
>            Priority: Minor
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: allowSolicitation.patch
>
>
> in contact forms field allowSolicitation is set to uiLabelMap.CommonY or 
> uiLabelMap.CommonN.
> it would be a good idea to force this value to Y or N because it is confusing 
> if you use more than one language
> additionaly different values break forms in other apps like crmsfa
> please see my patch
> Krzysztof Podejma

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to