[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504394
]
David E. Jones commented on OFBIZ-1041:
---------------------------------------
Okay, I was just looking at the code and it looks like this breaks the pattern
I noted as very important in my comments.
What this code does is internationalize what the user sees AND what is sent to
the server. That will break things and is a big problem.
What needs to happen whenever there is a i18n'ed label inside <option></option>
the value attribute on the option element MUST be used.
For example instead of:
<option>${uiLabelMap.CommonY}</option> (BAD)
you should use:
<option value="Y">${uiLabelMap.CommonY}</option> (GOOD)
> various values in allowSolicitation variable break some screens
> ----------------------------------------------------------------
>
> Key: OFBIZ-1041
> URL: https://issues.apache.org/jira/browse/OFBIZ-1041
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Krzysztof Podejma
> Assignee: Si Chen
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: allowSolicitation.patch
>
>
> in contact forms field allowSolicitation is set to uiLabelMap.CommonY or
> uiLabelMap.CommonN.
> it would be a good idea to force this value to Y or N because it is confusing
> if you use more than one language
> additionaly different values break forms in other apps like crmsfa
> please see my patch
> Krzysztof Podejma
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
