[
https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508490
]
Wickersheimer Jeremy commented on OFBIZ-1096:
---------------------------------------------
Adrian,
I checked the few changes you made, just one issue: you assign the class
"disabled" on disabled buttons, this works for text buttons, but won't with
images.
If for example i style nav-first with arrow-first.png, i would want to style
the corresponding disabled button with arrow-first-disabled.png (which would be
a grayed arrow pointing left).
So i will go back to adding "-disabled" to the base class.
About you other points:
1. Yes why not, in fact i would prefer removing all \n and keep the
appendWhitespace at the end of the pager rendering.
2. Indeed.
3. Tricky, the combobox represent the current page, the "1 of X" indicates the
records displayed, not the pages.
So IMO the current page should remain in the center.
Else i did not use uiLabels, but i guess i will add "Page" before the combobox,
and "rows" after the "1 - X of Y", this will make thing clearer i think.
> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: form-dtd.patch, form-dtd_2.patch,
> HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch,
> ModelForm-2.patch, ModelForm.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files
> in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well
> as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with
> the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk
> version.
> PS: I would like to use this issue to have your comments on another pager
> issue. The current implementation doesn't support pages that display more
> than one list form for the obvious reason that the only the parameters
> VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to
> differentiate the form.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
