[ 
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512629
 ] 

Adrian Crum commented on OFBIZ-1041:
------------------------------------

The problem still exists. From line 224 of  
applications/party/webapp/partymgr/party/editcontactmech.ftl:

      <select name="allowSolicitation">
        
<option>${(mechMap.partyContactMech.allowSolicitation)?if_exists}</option>
        
<option></option><option>${uiLabelMap.CommonY}</option><option>${uiLabelMap.CommonN}</option>
      </select>

If a user has selected a locale that doesn't use Y and N to represent Yes and 
No, then the data returned by this code will be invalid.

The code should be something like:

<select name="allowSolicitation">
  <#if (mechMap.partyContactMech.allowSolicitation)?exists >
    <#if (mechMap.partyContactMech.allowSolicitation?default("") == 
"Y")><option value="Y">${uiLabelMap.CommonY}</option></#if>
    <#if (mechMap.partyContactMech.allowSolicitation?default("") == 
"N")><option value="N">${uiLabelMap.CommonN}</option></#if>
  </#if>
  <option></option><option value="Y">${uiLabelMap.CommonY}</option><option 
value="N">${uiLabelMap.CommonN}</option>
</select>

Maybe Krzysztof can prepare an updated patch.


> various values in allowSolicitation variable  break some screens
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1041
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1041
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Krzysztof Podejma
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: allowSolicitation.patch
>
>
> in contact forms field allowSolicitation is set to uiLabelMap.CommonY or 
> uiLabelMap.CommonN.
> it would be a good idea to force this value to Y or N because it is confusing 
> if you use more than one language
> additionaly different values break forms in other apps like crmsfa
> please see my patch
> Krzysztof Podejma

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to