[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512784
]
Jacques Le Roux commented on OFBIZ-1041:
----------------------------------------
It's finally done :o)
When I did the changes I was a bit puzzled because I found some new operators
(at least ! and ??, see
http://freemarker.org/docs/dgui_template_exp.html#dgui_template_exp_missing_default)
but no use ot them in OFBiz. So I was not sure if I it was a good practice to
use them (it was late and I preferred to not take any risks). Something also
that prevent me at 1st to do it is that the freemarker plugins in Eclipse (I
use hudson.freemarker_ide_0.9.14) does not take care of them yet). But this
operators look cool (who will prefer default?() against ! ;o) and finally
thismorning I decided to begin to use them.
So I used this scheme (whitout unneded <#if (allowSolicitation)?exists > block
around)
<#if (()!"" == "Y")><option
value="test">${uiLabelMap.CommonY}</option></#if>
<#if (()!"" == "N")><option
value="N">${uiLabelMap.CommonN}</option></#if>
This definitively closes the "various values in allowSolicitation variable
break some screens" (https://issues.apache.org/jira/browse/OFBIZ-1041).
I used the same simple scheme everywhere but where no data was reloaded (like
apparently in EditCategoryProducts.ftl and EditProductPromoRules.ftl)
In trunk rev. 556373
Release4.0 revision: 556376, manually merged from trunk revision 556373 for
some files
Conflicts resolved by hand :
EditProductStorePaySetup.ftl
applications/party/webapp/partymgr/party/editcontactmech.ftl
genericaddress.ftl
editShoppingList.ftl
newcustomer.ftl
> various values in allowSolicitation variable break some screens
> ----------------------------------------------------------------
>
> Key: OFBIZ-1041
> URL: https://issues.apache.org/jira/browse/OFBIZ-1041
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Krzysztof Podejma
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: allowSolicitation.patch
>
>
> in contact forms field allowSolicitation is set to uiLabelMap.CommonY or
> uiLabelMap.CommonN.
> it would be a good idea to force this value to Y or N because it is confusing
> if you use more than one language
> additionaly different values break forms in other apps like crmsfa
> please see my patch
> Krzysztof Podejma
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
