Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

[Michael Brohl]

Hi Jacques,








Thanks,

Michael


Am 12.12.17 um 10:04 schrieb Jacques Le Roux (JIRA):

I propose to do it the other way around: when reviewing diffs, you can configure the IDE to ignore these white space changes. It works perfectly in Eclipse and you will not be bothered by such changes. In my view, trailing white spaces do not belong there and should be removed as part of the refactoring process. Else they would be there forever. To be precise, these are not false changes but intended changes to get rid of trailing white spaces.

     [ 
https://issues.apache.org/jira/browse/OFBIZ-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287290#comment-16287290
 ]

Jacques Le Roux commented on OFBIZ-9777:
----------------------------------------

hanks Michael, Julian,

Please Julian adjust your IDE or similar to not remove trailing white spaces 
when you create a patch, especially a big one, you may do that temporarily. 
Consider that else reviewers have to be confronted with a lot of false changes, 
thanks!

BTW I have added a warning in 
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
 for that

[FB] Package org.apache.ofbiz.product.imagemanagement
-----------------------------------------------------

                 Key: OFBIZ-9777
                 URL: https://issues.apache.org/jira/browse/OFBIZ-9777
             Project: OFBiz
          Issue Type: Sub-task
          Components: product
    Affects Versions: Trunk
            Reporter: Julian Leichert
            Assignee: Michael Brohl
            Priority: Minor
             Fix For: Upcoming Release

         Attachments: 
OFBIZ-9777_org.apache.ofbiz.product.imagemanagement_bugfixes.patch

smime.p7s
Description: S/MIME Cryptographic Signature