+1 to their removal. A quick grep lists the fields which have that flag. I'm not sure about the field in the entity component though! it might be needed in some unit tests?
framework/entity/entitydef/entitymodel_test.xml: <field name="testingName" type="name" enable-audit-log="true"/> applications/datamodel/entitydef/order-entitymodel.xml: <field name="quantity" type="fixed-point" enable-audit-log="true"></field> applications/datamodel/entitydef/order-entitymodel.xml: <field name="unitPrice" type="currency-precise" enable-audit-log="true"></field> applications/datamodel/entitydef/order-entitymodel.xml: <field name="changeByUserLoginId" type="id-vlong" enable-audit-log="true"></field> applications/datamodel/entitydef/order-entitymodel.xml: <field name="shipmentMethodTypeId" type="id" enable-audit-log="true"></field> applications/datamodel/entitydef/order-entitymodel.xml: <field name="carrierPartyId" type="id" enable-audit-log="true"></field> applications/datamodel/entitydef/order-entitymodel.xml: <field name="returnReasonId" type="id" enable-audit-log="true"> applications/datamodel/entitydef/order-entitymodel.xml: <field name="returnTypeId" type="id" enable-audit-log="true"> applications/datamodel/entitydef/order-entitymodel.xml: <field name="returnQuantity" type="fixed-point" enable-audit-log="true"><description>promised by the customer</description></field> applications/datamodel/entitydef/order-entitymodel.xml: <field name="receivedQuantity" type="fixed-point" enable-audit-log="true"><description>actually received from the customer</description></field> applications/datamodel/entitydef/order-entitymodel.xml: <field name="returnPrice" type="currency-amount" enable-audit-log="true"></field> On Wed, Apr 4, 2018 at 10:57 AM, pierre.gaudin <pierre.gau...@nereide.fr> wrote: > Hi, > > Thanks Nicolas to point to this issue. > > I also think that this attribute should be used only for technical purpose, > not for functional purposes. > > > Pierre > > > On 04/04/2018 08:54, Jacques Le Roux wrote: >> >> Hi, >> >> Moving this discussion from user ML >> >> I agree Nicolas, I see no reasons to OOTB enable audit log in any of the >> fields which currently supports it. Not sure if we need to go with extending >> entities. >> >> Note: the only entities concerned are OrderItem, OrderItemShipGroup, >> ReturnItem >> >> Jacques >> >> >> Le 03/04/2018 à 23:33, Nicolas Malin a écrit : >>> >>> Hello, >>> >>> There is a good example on issue OFBIZ-2483 [1]. Personally, I'm not in >>> favor to enable audit log in framework code base because impact the >>> performance. I suggest to convert all current activation to disable, prepare >>> some entity field with extend-entity that contains entity-audit-log on the >>> related component and inform on screen who used this table how enable the >>> audit log. >>> >>> But for that it's I also suggest to move the discussion to dev ;) >>> >>> Nicolas >>> >>> [1] https://issues.apache.org/jira/browse/OFBIZ-2483 Add History Function >>> to Returns so we can see who Created, Edited, Completed return >>> >>> On 03/04/2018 21:57, pierre.gaudin wrote: >>>> >>>> Hi all, >>>> >>>> In the definition of some entities, certain fields are set to >>>> enable-audit-log = true by default. >>>> >>>> Is there a reason for that? >>>> >>>> >>>> thanks, >>>> >>>> >>>> pierre >>>> >>> >>> >> >> >
