Hi Mathieu, thanks for your proposal. Just a few questions to get the whole picture:
1. do we really have a complexity problem here? The removed code seems not too complicated or long.
2. what do we lose with the removal? I see one can not only configure the ComponentContainer class but also set different loaders.
@all: are there any implementations which make use of this? Thanks and regards, Michael Am 10.06.19 um 19:33 schrieb Mathieu Lirzin:
Hello, To extend the containers loaded on startup, it is possible define a container element either in the global “ofbiz-containers.xml” file or in the “ofbiz-component.xml” file from each component. This redundancy adds extra complexity in the startup process for no good extensibility reason. The component container loader is more flexible since it allows developper to add new containers without touching the framework so it is better to only rely on this option. In order to simplify the startup process I am proposing to remove the "ofbiz-containers.xml" config file and hard-code the required base container which is loading the components which is currently defined in this file. What do people think? I have opened OFBIZ-11100 [1] with some patches demonstrating what I am exactly proposing. Thanks. [1] https://issues.apache.org/jira/browse/OFBIZ-11100
smime.p7s
Description: S/MIME Cryptographic Signature
