Hi Deepak, Happy to see your commits in action. :) Just a minor suggestion, we put Jira ticket ID in separate line in commit log. Also, add colon ':' in Thanks statement. And since the ticket type is 'Improvement', it seems to me, we should use 'Improved' instead of 'Fixed'.
Here is commit template for your quick reference https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template Following commit log template will help us in producing the monthly blog development details. Thanks for your cooperation. Best regards, Swapnil M Mane, ofbiz.apache.org On Sat, Sep 28, 2019 at 3:56 PM <deepakni...@apache.org> wrote: > Author: deepaknigam > Date: Sat Sep 28 10:26:09 2019 > New Revision: 1867663 > > URL: http://svn.apache.org/viewvc?rev=1867663&view=rev > Log: > Fixed: Serbian CommonEntityLabels for geo entity. (OFBIZ-11209) > Added missing entity label for Serbia. > Thanks Ulrich Heidfeld for your contribution. > > Modified: > > ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml > > Modified: > ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml > URL: > http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml?rev=1867663&r1=1867662&r2=1867663&view=diff > > ============================================================================== > --- > ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml > (original) > +++ > ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml > Sat Sep 28 10:26:09 2019 > @@ -8011,6 +8011,10 @@ > <value xml:lang="zh">圣皮埃尔和密克隆群岛</value> > <value xml:lang="zh-TW">è –çš®åŸƒçˆ¾å’Œå¯†å…‹éš†ç¾¤å³¶</value> > </property> > + <property key="Geo.geoName.SRB"> > + <value xml:lang="de">Serbien</value> > + <value xml:lang="en">Serbia</value> > + </property> > <property key="Geo.geoName.STP"> > <value xml:lang="ar">سان تومي وبرينسيبي</value> > <value xml:lang="de">Sao Tome und Principe</value> > > >
