Hi Taher,
Le 17/11/2019 à 19:16, Taher Alkhateeb a écrit :
Hi Jacques,
I'm not sure what convention over configuration has to do with what
you're saying :)
It was because of this sentence in the reference link
"This is a project specific convention that has no relation to any requirements
or limitations in Git. Yes, it is a fine convention for many projects but it should not
be required."
And yes I abused the concept a bit :) I see our template as a configuration.
Anyway, it makes sense. Most GIT editors consider the first line to be
subject, and third line onward is the body of the message. So perhaps
we can move the (OFBIZ-XXXX) to the end of the first line or maybe
make it the last line in the body or something like that.
Finally, like Gil, I prefer to keep the 2 infos on the same line. It would make
less sense to have the issue number inside the body of the message
Thanks
Jacques
On Sun, Nov 17, 2019 at 7:05 PM Jacques Le Roux
<jacques.le.r...@les7arts.com> wrote:
Hi,
While working in Eclipse with Git (ie using eGit which is not my favourite
tool). I found a warning telling me:
"Second line should be empty to separate commit message header from body"
It was argued that it's only a convention[1], but don't we prefer "convention over
configuration"?
I suggest to change our template according to the convention, ie separate the
title from the issue number or put the number on the same line (split
sometimes) than the title
[1]https://bugs.eclipse.org/bugs/show_bug.cgi?id=475845
What do you think?
Jacques
