Hi All,

Recently we saw some postings in various threads how to deal with commits
from contributors coming via pull requests in Github.
If I understand it correctly, the issue we're dealing with has to do with
the commit message (as defined in
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
).
After a code contribution has been accepted by a committer, this commit
message appears in:

   1. the OFBiz repo
   2. a posting to the commit@ mailing list
   3. in the referenced JIRA ticket (as a comment, and in the commit
   section, see e.g. https://issues.apache.org/jira/browse/OFBIZ-10954)

Elements of the commit message are also used in the regularly occurring
blog posts of the project.

With our repositories available via Github, we can expect that more and
more contributors work within their local clones, and publish their code
changes (commits) in their own public forks on Github and from there issue
a pull request to get these contributions evaluated by community members
and when good incorporated into the OFBiz repositories.

A pull request can contain one or more commits (from the contributor - or
in git parlance: the author).

So, when the commit message by the contributor (author) of each of his
commits is formatted in accordance with the commit-message template there
is nothing that stands in the way to take it to the next step. Which is the
evaluation of the contribution by other community members.

Is my assessment so far correct?

Best regards,

Pierre Smits

*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
*Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
since 2008*
Apache Steve <https://steve.apache.org>, committer

Reply via email to