[ 
https://issues.apache.org/jira/browse/OFBIZ-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Eckard updated OFBIZ-1514:
------------------------------

    Description: 
If a product has multiple keywords with identical roots and different relevancy 
weights and the product is within a set of search results that span multiple 
pages, then it will be duplicated in the results display. This is because 
ProductSearch is doing a "distinct" on productId, relevancyWeight(s) instead of 
grouping by the productId. (And the attempt at duplicate removal only happens 
on a page-by-page basis.)

I'm attaching a small proof-of-concept patch to make grouping by productId the 
default - it appears to work well with various combinations of search criteria 
(multiple keywords, features, feature cats, categories, etc.) but I haven't 
done a tremendous amount of testing. (Only using PostgreSQL and Derby)

>From the comments in the ProductSearch code it looks like it was done this way 
>once, but it may have caused problems with Oracle. Does anyone know what that 
>problem was, or can anyone check this patch against oracle?

  was:
If a product has multiple keywords with identical roots and different relevancy 
weights and the product is within a set of search results that span multiple 
pages, then it will be duplicated in the results display. This is because 
ProductSearch is doing a "distinct" on productId, relevancyWeight(s) instead of 
grouping by the productId.

I'm attaching a small proof-of-concept patch to make grouping by productId the 
default - it appears to work well with various combinations of search criteria 
(multiple keywords, features, feature cats, categories, etc.) but I haven't 
done a tremendous amount of testing. (Only using PostgreSQL and Derby)

>From the comments in the ProductSearch code it looks like it was done this way 
>once, but it may have caused problems with Oracle. Does anyone know what that 
>problem was, or can anyone check this patch against oracle?


> Duplicates in Search Results
> ----------------------------
>
>                 Key: OFBIZ-1514
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1514
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Joe Eckard
>            Priority: Minor
>         Attachments: patch.txt
>
>
> If a product has multiple keywords with identical roots and different 
> relevancy weights and the product is within a set of search results that span 
> multiple pages, then it will be duplicated in the results display. This is 
> because ProductSearch is doing a "distinct" on productId, relevancyWeight(s) 
> instead of grouping by the productId. (And the attempt at duplicate removal 
> only happens on a page-by-page basis.)
> I'm attaching a small proof-of-concept patch to make grouping by productId 
> the default - it appears to work well with various combinations of search 
> criteria (multiple keywords, features, feature cats, categories, etc.) but I 
> haven't done a tremendous amount of testing. (Only using PostgreSQL and Derby)
> From the comments in the ProductSearch code it looks like it was done this 
> way once, but it may have caused problems with Oracle. Does anyone know what 
> that problem was, or can anyone check this patch against oracle?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to