Hi all, In this thread we discussed improvements to the Contributing via Git and Github page in Confluence (see [1]). Some were then adamant that the page should have the WIP status referenced in the subject/title.
However, since then the page hasn't changed. If nothing comes forward in the coming days, I will remove the WIP status from the subject/title. After that, contributors can continue to improve the page, like they can improve any other page that doesn't have the WIP status in the subject/title [1] https://cwiki.apache.org/confluence/display/OFBIZ/Contributing+via+Git+and+Github+-+WIP Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since 2008 (without privileges) *Apache Trafodion <https://trafodion.apache.org>, Vice President* *Apache Directory <https://directory.apache.org>, PMC Member* Apache Incubator <https://incubator.apache.org>, committer Apache Steve <https://steve.apache.org>, committer On Sat, Feb 22, 2020 at 10:12 AM Michael Brohl <michael.br...@ecomify.de> wrote: > It seems you just removed the work in progess notes from the page > without waiting for the review I've announced. > > The page should be marked as WIP until we agree on the processes > described there, IMO. > > Thanks, > > Michael > > > Am 22.02.20 um 08:59 schrieb Pierre Smits: > > @Michal, > > > > Your comments have been addressed and noted. You can continue to review, > > discuss and suggest changes... > > > > Met vriendelijke groet, > > > > Pierre Smits > > *Proud* *contributor* (but unfortunately without privileges)* of* Apache > > OFBiz <https://ofbiz.apache.org/>, since 2008 > > > > *Apache Trafodion <https://trafodion.apache.org>, Vice President* > > *Apache Directory <https://directory.apache.org>, PMC Member* > > Apache Incubator <https://incubator.apache.org>, committer > > Apache Steve <https://steve.apache.org>, committer > > > > > > On Fri, Feb 21, 2020 at 9:24 AM Michael Brohl <michael.br...@ecomify.de> > > wrote: > > > >> I made a comment just yesterday. The page needs review and this might > >> take some time. > >> > >> Michael > >> > >> > >> Am 21.02.20 um 09:20 schrieb Pierre Smits: > >>> Hi All, > >>> > >>> It seems feedback on the 'Contributing via Git and Github' page in our > >> wiki > >>> has subsided. Shortly I will apply lazy consensus to remove its WiP > >> status. > >>> Met vriendelijke groet, > >>> > >>> Pierre Smits > >>> *Proud* *contributor* (but unfortunately without privileges)* of* > Apache > >>> OFBiz <https://ofbiz.apache.org/>, since 2008 > >>> > >>> *Apache Trafodion <https://trafodion.apache.org>, Vice President* > >>> *Apache Directory <https://directory.apache.org>, PMC Member* > >>> Apache Incubator <https://incubator.apache.org>, committer > >>> Apache Steve <https://steve.apache.org>, committer > >>> > >>> > >>> On Fri, Feb 14, 2020 at 1:55 PM Jacques Le Roux < > >>> jacques.le.r...@les7arts.com> wrote: > >>> > >>>> +1 > >>>> > >>>> Jacques > >>>> > >>>> Le 14/02/2020 à 12:29, Pierre Smits a écrit : > >>>>> Hi Nicolas, > >>>>> > >>>>> Your suggestion to show only open PRs is way better. > >>>>> > >>>>> I will update the page. > >>>>> > >>>>> Thanks! > >>>>> > >>>>> Best regards, > >>>>> > >>>>> Pierre Smits > >>>>> *Proud* *contributor* (but without privileges)* of* Apache OFBiz > >>>>> <https://ofbiz.apache.org/>, since 2008 > >>>>> > >>>>> *Apache Trafodion <https://trafodion.apache.org>, Vice President* > >>>>> *Apache Directory <https://directory.apache.org>, PMC Member* > >>>>> Apache Incubator <https://incubator.apache.org>, committer > >>>>> Apache Steve <https://steve.apache.org>, committer > >>>>> > >>>>> > >>>>> On Fri, Feb 14, 2020 at 12:15 PM Nicolas Malin < > >> nicolas.ma...@nereide.fr > >>>>> wrote: > >>>>> > >>>>>> Hi, > >>>>>> On 31/01/2020 15:53, Pierre Smits wrote: > >>>>>> > >>>>>> Pull Request available on Github can be seen in the local clone. In > >>>> order > >>>>>> to have this working, the following line should be added to the git > >>>>>> configuration of the local clone: > >>>>>> > >>>>>> fetch = +refs/pull/**/head:refs/remotes/origin/pr/** > >>>>>> > >>>>>> > >>>>>> Preferably this line should exist before the 'fetch = > >>>>>> +refs/heads/*:refs/remotes/origin/*' of the 'Github' remote. > >>>>>> > >>>>>> After some tries I propose to use > >>>>>> > >>>>>> fetch = +refs/pull/*/merge:refs/remotes/pr/* > >>>>>> > >>>>>> instead of > >>>>>> > >>>>>> fetch = +refs/pull/**/head:refs/remotes/origin/pr/** > >>>>>> > >>>>>> The first list pull request available to merge, and the second list > >> all > >>>>>> pull request (closed included) > >>>>>> > >>>>>> Nicolas > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >> > >