We should not compound additional functions (even though these are corrections) into apps that are clearly not intended for parties outside of the domain (in this case warehouse managers to the order app).
Enhanced data in PR #117 shows that such is not needed. We should close the ticket and create a new one to remove the functions. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since 2008 (without privileges) *Apache Trafodion <https://trafodion.apache.org>, Vice President* *Apache Directory <https://directory.apache.org>, PMC Member* Apache Incubator <https://incubator.apache.org>, committer Apache Steve <https://steve.apache.org>, committer On Tue, Jun 2, 2020 at 3:10 PM Pierre Smits <pierresm...@apache.org> wrote: > A warehouse manager has ample functions available in the facility app to > view pick sheets, correct? > If not so, why are there screens like: > [1] > https://demo-stable.ofbiz.apache.org/facility/control/PicklistManage?facilityId=MyRetailStore > [2] > https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=MyRetailStore > [3] https://demo-stable.ofbiz.apache.org/facility/control/VerifyPick > > to be used by the warehouse manager to see what sheet is available to > process? > > Did we include the pick sheet in the order app to circumvent something? A > warehouse manager should not have access to functions/widgets/etc. in the > order component. > > > Met vriendelijke groet, > > Pierre Smits > *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since > 2008 (without privileges) > > *Apache Trafodion <https://trafodion.apache.org>, Vice President* > *Apache Directory <https://directory.apache.org>, PMC Member* > Apache Incubator <https://incubator.apache.org>, committer > Apache Steve <https://steve.apache.org>, committer > > > On Tue, Jun 2, 2020 at 2:42 PM Pawan Verma <pawan.ve...@hotwaxsystems.com> > wrote: > >> Hello Devs, >> >> I've discussed with Arun Patidar who added this support and as per the >> conclusion, this report is for warehouse manager not for the picker. >> >> OFBIZ-11781 is a valid issue, we should correct the currency symbol. >> >> @Suraj Khurana <suraj.khur...@hotwax.co> your proposition looks good, we >> can change this confusing label like Print Order Sheet? Thoughts? >> -- >> Thanks & Regards >> Pawan Verma >> Technical Consultant >> *HotWax Systems* >> *Enterprise open source experts* >> http://www.hotwaxsystems.com >> >> >> On Mon, Jun 1, 2020 at 10:09 PM Pierre Smits <pierresm...@apache.org> >> wrote: >> >> > With the enhancements provided through PR #117 (see [1]), I have >> created a >> > few demo party records for only warehousing roles to enhance the user >> > experience for such parties (having only access to the facility app): >> > >> > See below: >> > >> > *For a warehouse manager* >> > <!-- Party partyId="employee34" --> >> > <Party partyId="employee34" partyTypeId="PERSON" >> > statusId="PARTY_ENABLED"/> >> > <Person partyId="employee34" lastName="WarehousingMgr" >> > firstName="DemoEmployee" middleName="34"/> >> > <PartyRole partyId="employee34" roleTypeId="EMPLOYEE" >> > fromDate="2001-05-13 00:00:00.0"/> >> > <PartyRole partyId="employee34" roleTypeId="MANAGER" >> > fromDate="2001-05-13 00:00:00.0"/> >> > <PartyStatus partyId="employee34" statusId="PARTY_ENABLED" >> > statusDate="2001-01-01 12:00:00.0"/> >> > <UserLogin userLoginId="employee34" partyId="employee34" >> > currentPassword="{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a" >> > requirePasswordChange="N"/> >> > >> > *For a picker* >> > <!-- Party partyId="employee39" --> >> > <Party partyId="employee39" partyTypeId="PERSON" >> > statusId="PARTY_ENABLED"/> >> > <Person partyId="employee39" lastName="Picker" >> firstName="DemoEmployee" >> > middleName="39"/> >> > <PartyRole partyId="employee39" roleTypeId="EMPLOYEE" >> > fromDate="2001-05-13 00:00:00.0"/> >> > <PartyRole partyId="employee39" roleTypeId="PICKER" >> > fromDate="2001-05-13 00:00:00.0"/> >> > <PartyStatus partyId="employee39" statusId="PARTY_ENABLED" >> > statusDate="2001-01-01 12:00:00.0"/> >> > <UserLogin userLoginId="employee39" partyId="employee39" >> > currentPassword="{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a" >> > requirePasswordChange="N"/> >> > >> > *For a packer * >> > <!-- Party partyId="employee36" --> >> > <Party partyId="employee36" partyTypeId="PERSON" >> > statusId="PARTY_ENABLED"/> >> > <Person partyId="employee36" lastName="Packer" >> firstName="DemoEmployee" >> > middleName="36"/> >> > <PartyRole partyId="employee36" roleTypeId="EMPLOYEE" >> > fromDate="2001-05-13 00:00:00.0"/> >> > <PartyRole partyId="employee36" roleTypeId="PACKER" >> > fromDate="2001-05-13 00:00:00.0"/> >> > <PartyStatus partyId="employee36" statusId="PARTY_ENABLED" >> > statusDate="2001-01-01 12:00:00.0"/> >> > <UserLogin userLoginId="employee36" partyId="employee36" >> > currentPassword="{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a" >> > requirePasswordChange="N"/> >> > >> > [1] Improved: Update Data Sets >> > <https://github.com/apache/ofbiz-framework/pull/117> >> > >> > With those enhancements in play in trunk, we can see what particular >> role >> > playing parties can and can't do. >> > <https://github.com/apache/ofbiz-framework/pull/117> >> > Met vriendelijke groet, >> > >> > Pierre Smits >> > *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> >> since >> > 2008 (without privileges) >> > >> > *Apache Trafodion <https://trafodion.apache.org>, Vice President* >> > *Apache Directory <https://directory.apache.org>, PMC Member* >> > Apache Incubator <https://incubator.apache.org>, committer >> > Apache Steve <https://steve.apache.org>, committer >> > >> > >> > On Mon, Jun 1, 2020 at 6:20 PM Pierre Smits <pierresm...@apache.org> >> > wrote: >> > >> > > So we're talking about the pdf generated for a picksheet in the order >> app >> > > (see [1])? >> > > >> > > A warehouse manager has functions available in the facility app to >> view >> > > what needs to be picked and assign that to a picker (see [2] and [3], >> > > correct? >> > > Then why would he need access to the order app? >> > > >> > > >> > > [1] >> > > >> > >> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10090 >> > > [2] >> > > >> > >> https://demo-trunk.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse >> > > [3] >> > > >> > >> https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse >> > > >> > > Met vriendelijke groet, >> > > >> > > Pierre Smits >> > > *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> >> > since >> > > 2008 (without privileges) >> > > >> > > *Apache Trafodion <https://trafodion.apache.org>, Vice President* >> > > *Apache Directory <https://directory.apache.org>, PMC Member* >> > > Apache Incubator <https://incubator.apache.org>, committer >> > > Apache Steve <https://steve.apache.org>, committer >> > > >> > > >> > > On Mon, Jun 1, 2020 at 1:38 PM Suraj Khurana <suraj.khur...@hotwax.co >> > >> > > wrote: >> > > >> > >> Hello Pawan, >> > >> >> > >> IMO, this label is confusing/misleading, this is order pick list or >> > >> basically order details for warehouse manager to keep as a copy with >> > >> himself. It will be always on each order level on the create picklist >> > >> page. >> > >> So that before creating a picklist he can check/select which orders >> to >> > >> pick. >> > >> >> > >> Actual pick sheet (used by picker) is something available under >> manage >> > >> picklist i.e. after picklist is created, which tells picker which >> item >> > to >> > >> pick from which location, no further order details. >> > >> >> > >> Am I missing something? >> > >> >> > >> -- >> > >> Best Regards, >> > >> Suraj Khurana >> > >> SENIOR TECHNICAL CONSULTANT >> > >> mobile: +91 9669750002 >> > >> email: suraj.khur...@hotwax.co >> > >> *www.hotwax.co <http://www.hotwax.co/>* >> > >> >> > >> >> > >> On Mon, Jun 1, 2020 at 3:09 PM Pawan Verma < >> > pawan.ve...@hotwaxsystems.com >> > >> > >> > >> wrote: >> > >> >> > >> > Hello Devs, >> > >> > >> > >> > While working on OFBIZ-11781, issue of the distorted currency >> symbol. >> > >> > Pierre asked: Are we confident that prices and currency symbols >> are a >> > >> > requirement for a pick sheet? >> > >> > >> > >> > The important information for picket is Item, quantity, and >> location. >> > >> > Pickers really don't need the unit price, subtotal, or other >> > >> price-related >> > >> > information. >> > >> > >> > >> > Should we remove the unit price and subtotal information from a >> pick >> > >> sheet >> > >> > report? Or should we fix OFBIZ-11781 only? >> > >> > >> > >> > Your suggestions are appreciated! >> > >> > -- >> > >> > Thanks & Regards >> > >> > Pawan Verma >> > >> > Technical Consultant >> > >> > *HotWax Systems* >> > >> > *Enterprise open source experts* >> > >> > http://www.hotwaxsystems.com >> > >> > >> > >> >> > > >> > >> >
