Thanks for the reply. The link essentially says "to make postgres consistent with the other databases". I researched it out, and found that *every single* supported database has a text type that goes over 255 char! (and gets used for type "very-long")
I know I do, and I would imagine people could easily go over 255 char when writing things like a comment or description about something. Would it make sense to change description and comment field types for all databases to be whatever that database has for type "very-long"? If so, do I submit this as a JIRA issue? ________________________________________ From: Jacques Le Roux [jacques.le.r...@les7arts.com] Sent: Tuesday, August 11, 2020 6:30 AM To: dev@ofbiz.apache.org Subject: Re: varchar(255) in fieldtypepostgres.xml Hi, Please check https://svn.apache.org/viewvc?view=revision&revision=1697590 This is also related https://markmail.org/message/xuwhnbmum3evejwk Jacques Le 10/08/2020 à 20:30, Development a écrit : > In /framework/entity/fieldtype/fieldtypepostgres.xml I saw some lines like: > > <field-type-def type="comment" sql-type="VARCHAR(255)" > java-type="String"/> > <field-type-def type="description" sql-type="VARCHAR(255)" > java-type="String"/> > <field-type-def type="long-varchar" sql-type="VARCHAR(255)" > java-type="String"/> > > > In postgres, using "VARCHAR(255)" saves no space in the database over using > "VARCHAR" (with no number) or "TEXT", the only difference is that the 255 > slows it down with error checking. > > Is there any reason on the ofbiz side to not just change this to plain > "VARCHAR" or "TEXT"? Like perhaps the forms would only display the first 255 > characters of it or something? > > Obviously I can do this for my own installation. I'm asking here cause it > feels like something that should be pushed upstream. > > > > > > > > CONFIDENTIALITY NOTICE: This message is intended only for the use of the > person or organization to which it is addressed or was intended to be > addressed, and may contain information that is privileged, confidential and > exempt from disclosure under applicable law. If the reader of this message is > not the intended recipient, or responsible for delivering the message to the > intended recipient, you are hereby notified that any dissemination, > distribution or copying of this communication is strictly prohibited. If you > have received this communication in error, please notify the sender > immediately by email and delete the original message immediately . The > sender, its subsidiaries and affiliates, do not accept liability for any > errors, omissions, corruption or virus in the contents of this message or any > attachments that arise as a result of e-mail transmission. Thank you. CONFIDENTIALITY NOTICE: This message is intended only for the use of the person or organization to which it is addressed or was intended to be addressed, and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, or responsible for delivering the message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by email and delete the original message immediately . The sender, its subsidiaries and affiliates, do not accept liability for any errors, omissions, corruption or virus in the contents of this message or any attachments that arise as a result of e-mail transmission. Thank you.
