Hi Taher,
Inline...
Le 12/11/2021 à 14:20, Taher Alkhateeb a écrit :
Hello Everyone,
From my understanding, fromDate and thruDate are primarily used for historical record purposes. This is useful only if a context exists such as in
relation to an Order, WorkEffort, Request or something like that.
FromDate and thruDate can also be useful in case of auditing. At the moment, PartyRoles can only be removed by their own users. I guess it's on
purpose because of the explanation you give below. Before reverting, I was interested in Pierre's solution provided at OFBIZ-5980, despite the
discussion at OFBIZ-5959, because of the audit aspect. Nothing better for a person to hide something that be able to erase his/her own role. But in
OFBiz, as we already discussed many times, it's not the goal of PartyRole that misses the organisation context. This is rather and correctly handled
by PartyRelationship where the organisation context is present. So it was a red herring as you clearly describe below.
I'll do a a more comprehensive post in this thread.
Jacques
The PartyRole entity on the other hand has a different purpose which I think is not context-bound. It is only used in other contexts to make sure
that a certain party has access to a certain role so the context can be applied. We can say it's almost like a security entity and it serves many
other entities but has no significant value on its own (e.g. I don't care when did we classify someone as customer, I care when was his / her first
order)
Hence history in PartyRole does not seem to serve any logical purpose (unless I'm missing something) and perhaps would lead to higher complexity for
no immediate realized value.
On 11/12/21 14:00, Michael Brohl wrote:
Hi Gil,
thanks for the summary and links to previous discussions and issues.
In my opinion, the conclusion is still valid and I agree to close the pending issues as
"Won't do".
Thanks and best regards,
Michael Brohl
ecomify GmbH - www.ecomify.de
Am 12.11.21 um 10:07 schrieb Gil Portenseigne:
Hello,
I'm starting a new thread to discuss with the community about an Improvement
that has been submitted by Pierre Smits [1]
This topic has already been discussed in the past [2] and was conclude by a
lazy consensus not to implement PartyRole lifespan into OFBiz.
Recently, this improvement was discussed again in Jira [3], and partly commited, before being reverted when big blocking side effect where
discovered.
A more detailed summary has been made by Jacques here [4].
The enhancement is about adding fromDate and thruDate fields onto PartyRole
entity, modifying its primary key (fromDate)
The fact is that a such big subject need to be addressed with the community
consensus, as it is not trivial.
Please let us know you thoughts about this task and let's decide, if we need to organize or if we need to close pending Jira with reference to
this discussion ?
Thanks,
Gil
[1] https://issues.apache.org/jira/browse/OFBIZ-5959
[2]
https://markmail.org/message/pqrmv5vpjgm6iigq#query:+page:1+mid:isaoze65bbciuytc+state:results
[3] https://issues.apache.org/jira/browse/OFBIZ-5980
(https://issues.apache.org/jira/browse/OFBIZ-5980?focusedCommentId=17441274&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17441274)
[4]
https://issues.apache.org/jira/browse/OFBIZ-5980?focusedCommentId=17441274&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17441274
