I just want to make it clear to anyone reading that actually yes, there has been discussion in the past about understanding the context of labels and that the same word in English can mean different things depending on that context. For this reason labels shouldn't be merged when they are used for different contexts, ideally the label key would be clear about the context a label is being used in.
Michael is currently one of the few committers actively performing code reviews and to claim he is trolling is an insult to the time he is volunteering and achieves nothing but to harm the project and community. My two cents. Regards Scott On Tue, 25 Jan 2022, 14:01 Pierre Smits, <[email protected]> wrote: > Michael, > > I told you before in (other) tickets to stop trolling me through your > complaints in the tickets I am working on. You continue to do this. > Your remarks about you not committing the code contributions of > unprivileged contributors are totally inappropriate. Not appropriate in > ticket comments, nor in the mailing lists of the project. Nobody is > strong-arming you to commit or merge improvements. Nobody is expecting you > ever will. > Stop trying to pressure fellow contributors, collaborating to improve > OFBiz, to follow your dictate by your attempt to frame a narrative that > there is an agreement about how contributors are to contribute what, where > and when. > Such narrative is solely intended to dictate the direction of the project > for your self serving purposes, resulting in alienating fellow contributors > from collaborating in the OFBiz project to get improvements into its > repositories. > > There has never been such an agreement on how, what, where and when to > contribute in the OFBiz community. Nor on the specific subject of what the > correct translation label that is to be used in OFBiz screens and forms. > No discussion on that latter subject has ever been started on the dev > mailing list, nor is there any series of postings on that list that could > lead to someone being able to claim that a kind of consensus could be > derived from such a thread. > > It appears, IMO, that you don't want what is for the good of the public > through the deliverables of the OFBiz project. > Your business needs and goals are not the concerns of the project, nor the > concerns of the contributors not paid by you(r company). > You keep your Ecomify rules re OFBiz to yourself and for your employees, > instead of presenting them as rules (or agreements) of the project. In this > project there are no such 'contribution' rules. > There are only guidelines, and precedents established over time within the > project. And these indicate that anything goes. > > If you want to change what the way is how contributions are done to the > project, you start a discussion on the dev mailing list of the project and > work that discussion towards a consensus. Alternatively you follow the lead > of what many of your fellow privileged contributors do in this project > nowadays. > > Again: s*top trolling me*. You bring nothing new to the tickets I am > working. Keep your complaints to yourself, or use them to create a positive > change to the project that will make OFBiz more appealing, more > trustworthy, attracting a greater diversity of contributors instead of a > negative change. > > If you want to improve OFBiz, go work the tickets that have your name as > the assignee to a successful conclusion (or take those of the contributors > paid by your company, or - if that is all done - take those that are > unassigned as there are plenty of possibilities there), instead of > harassing fellow contributors and me collaborating to improve OFBiz. > > > > Pierre Smits > *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since > 2008 (without privileges) > Proud contributor to the ASF since 2006 > > *Apache Directory <https://directory.apache.org>, PMC Member* > > > On Mon, Jan 24, 2022 at 3:57 PM Michael Brohl (Jira) <[email protected]> > wrote: > > > > > [ > > > https://issues.apache.org/jira/browse/OFBIZ-12489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481153#comment-17481153 > > ] > > > > Michael Brohl commented on OFBIZ-12489: > > --------------------------------------- > > > > Thanks Jacques. > > > > I think you misunderstood my point respectively I made myself not clear > > enough. I know that we agreed upon the use of common labels vs. specific > > labels and simply put a reminder to give context. I didn't meant to say > > that you don't care about labels and I'm sorry if it came across this > way. > > > > I totally agree with your statement "I have always thought that example > is > > better than commanding." > > > > In this case, I do not think the lack of example is the problem. We've > > spent a lot of energy together to explain the points with common vs. > > specific labels and quite a few issues were resolved as "Won't do" in > this > > course. > > > > Being unfair was in no way targeted to you but to the contributor who > > seems to intentionally ignore past decisions and still tries to sneak in > > his point of view through contributions, often not even mentioning those > > changes in the commit messages. > > > > As a result, I won't commit those changes but insist that the contributor > > does the correction before the changes go to the codebase. Why should > > anyone else be bothered with this task than the contributor himself? > > > > Not sure if it will be a lesson because it had no consequences for the > > contributor. Where's the learning effect then? > > > > I will spent my time reviewing and commenting the PR's which I did the > > last days. I'm not sure if I am able or willing to spent my time > correcting > > things which easily could have been avoided in the first place, we will > see. > > > > > Product Prices - VIEW permissions > > > --------------------------------- > > > > > > Key: OFBIZ-12489 > > > URL: https://issues.apache.org/jira/browse/OFBIZ-12489 > > > Project: OFBiz > > > Issue Type: Improvement > > > Components: product/catalog > > > Affects Versions: Upcoming Branch > > > Reporter: Pierre Smits > > > Assignee: Pierre Smits > > > Priority: Major > > > Labels: permissions, price, product, trust, usability, ux > > > Fix For: Upcoming Branch > > > > > > > > > Currently, a user with only 'VIEW' permissions, as demonstrated in > trunk > > demo with userId = auditor, accessing the product prices screen, sees > > editable fields and/or triggers (to requests) reserved for users with > > 'CREATE' or 'UPDATE' permissions. > > > See (test with): > > > https://localhost:8443/catalog/control/EditProductPrices?productId=WG-9943 > > > > > > > > -- > > This message was sent by Atlassian Jira > > (v8.20.1#820001) > > >
