Hi,
Finally I attached the patch to upgrade to Gradle 7.6.0
(OFBIZ-12400-windows.patch) at OFBIZ-12400.
Small change: rather than manually copying the checksum from
https://gradle.org/release-checksums I followed Gradle advice at
https://docs.gradle.org/current/userguide/gradle_wrapper.html#wrapper_checksum_verification
I'm ready to push when the *nix version will be ready.
Jacques
Le 02/12/2022 à 11:23, Jacques Le Roux a écrit :
Hi Eugen,
Actually I can live with changing java_home by hand instead of using a batch
file, not a bid deal.
I only have now to test these small changes in init-gradle-wrapper.ps1
- Invoke-WebRequest -outf gradle\wrapper\gradle-wrapper.jar
https://github.com/gradle/gradle/raw/v6.5.1/gradle/wrapper/gradle-wrapper.jar
+ Invoke-WebRequest -outf gradle\wrapper\gradle-wrapper.jar
https://github.com/gradle/gradle/blob/v7.6.0/gradle/wrapper/gradle-wrapper.jar
Set-ItemProperty 'hklm:\SYSTEM\CurrentControlSet\Control\Session
Manager\Environment' -name "__PSLockdownPolicy" -Value 4
} else {
- Invoke-WebRequest -outf gradle\wrapper\gradle-wrapper.jar
https://github.com/gradle/gradle/raw/v6.5.1/gradle/wrapper/gradle-wrapper.jar
+ Invoke-WebRequest -outf gradle\wrapper\gradle-wrapper.jar
https://github.com/gradle/gradle/blob/v7.6.0/gradle/wrapper/gradle-wrapper.jar
}
-$expected = "33b0acb4572934fc1dd7d5880c65036724974e06"
+$expected = "c5a643cf80162e665cc228f7b16f343fef868e47d3a4836f62e18b7e17ac018a"
Should be soon...
Jacques
Le 02/12/2022 à 10:25, Eugen Stan a écrit :
Hi Jaques,
Any luck on this?
I use sdkman to switch jdk's on linux.
https://sdkman.io/install
I noticed it has some Windows options as well, maybe they will work for you ?!
I try to stay away from customizations since most of the time they are not
worth the effort.
If the build is slow it might also be an indication that we need to address the
root cause instead of avoiding it.
Having personal build customization that avoid the issues will make the false
believe the issue does not exist.
Also I don't imagine other people will use the same tricks so it will be harder
to relate to their issues / experiences in running OFBiz.
If the CI is building and other people are also building the project the PR
should be moved forward.
IMO, personal customization should not block the project moving forward.
I do hope you get to the bottom of this on your machine.
I don't use Windows myself, but I know a lot of people do and they should be
able to run OFBiz.
Regards,
Eugen
On 30.11.2022 19:39, Jacques Le Roux wrote:
I found the cause. For performance reason, and especially in order to be able to quickly switch from a JDK version to another, I use a batch file
to copy over JDKs to a RAM Disk. So java_home is always the same: this RAM Disk.
It has been working since Java 8, It now fails with JDK 17 (from what I have
read I guess since one version of JDK 16).
When setting java_home to the initial location of JDK 17, instead of the RAM
Disk, it works. I get only 2 warnings when compiling.
I'll have another look ASAP...
Le 30/11/2022 à 16:41, Jacques Le Roux a écrit :
After upgrading non-functional changes at OFBIZ-12400 (Java code, AsciiDoc versions, Groovy from 2.5.18 to 3.0.13), we can focus on Gradle and
JDK version.
With last Java 17 and still Gradle 6.5,of of course the same error than before:
"does not export com.sun.tools.javac.code to unnamed module"
With last Java 17 and Gradle 7.6, also the same error than before:
Execution failed for task ':compileJava'.
> Error while evaluating property 'javaVersion' of task ':compileJava'.
> Cannot invoke "java.nio.file.Path.toString()" because the return value of
"java.nio.file.Path.getFileName()" is null
I'll continue to dig starting from https://github.com/gradle/gradle/issues/20837 (notably last comment). It seems a not so obvious issue. I don't
think it's related to my Windows version, but not sure...
Le 30/11/2022 à 13:24, Jacques Le Roux a écrit :
Hi Eugen,
As you know I'm still on Win7 and was able to manage all related issues so far
(like the need to use npm 13.14.0 locally in build.gradle)
To simplify things I just committed the non functional Java changes unrelated to Gradle and JDK upgrades, not the same than your for CsrfUtil
class.
I tried several mixed things w/o success so far. I'll continue and inform you
here later.
Thanks
Jacques
Le 29/11/2022 à 12:12, Ioan Eugen Stan a écrit :
An update to this:
I've rebased the PR for gradle upgrade
https://issues.apache.org/jira/browse/OFBIZ-12400
https://github.com/apache/ofbiz-framework/pull/354
I've bumped gradle to 7.6 .
I started ofbiz with temurin jdk17 and it works (with warnings and some
errors).
See screenshot in PR.
The CI build passes.
Can you please review @Jacques ?
I do hope this will help move things forward.
Eugen
On 2022/11/29 09:55:02 eugen.s...@netdava.com wrote:
Hi,
There are some open issues about this:
https://issues.apache.org/jira/browse/OFBIZ-10757 - jdk 11
https://issues.apache.org/jira/browse/OFBIZ-12399 - jdk 17
https://issues.apache.org/jira/browse/OFBIZ-12400 - gradle 7.x for jdk17
There is also a PR for gradle upgrade
https://github.com/apache/ofbiz-framework/pull/354
Gradle upgrade is a pre-requisite for JDK upgrade.
I remember some issues with project not generating some docs as part of build
on some system.
I think this should not be considered an upgrade blocker IMO.
Since we are using third party libraries that might not support all platforms.
I really hope this gets merged.
Regads,
Eugen
