Oops, i did a fixup commit with push force that remove all comments in the pull request... Will not do that again.
I fixed the detected typo. gil On 27/01/23 02:56, Jacques Le Roux wrote: > Ah OK, sounds better indeed > > Le 27/01/2023 à 14:06, gil.portenseigne a écrit : > > The idea is not to modify the files, but to add a comment into the pull > > request. Those allowing each reviewer to check the viewed checkbox if a > > comment is present, to collapse already reviewed files. > > > > So no need further action, apart the real code modification request, > > when commiting the code. > > > > On 27/01/23 12:00, Jacques Le Roux wrote: > > > Hi Gil, Daniel, > > > > > > I agree Gil, I just tried before seeing your message and came to the same > > > conclusion. > > > > > > With a comment at top we would need to remove it later, right? Could be > > > easy if it's the same unique words in every file. > > > > > > Jacques > > > > > > Le 27/01/2023 à 10:41, gil.portenseigne a écrit : > > > > Hi Daniel, Jacques, > > > > > > > > I wonders the same, the "Review changes" do not seems to concern one > > > > file but the whole pull request, there is a review checkbox, but it > > > > seems to be personal, i checked the first one > > > > (AcctgAdminServices.groovy) for testing purpose. > > > > > > > > What we could do is to add a comment at the start of each file, to let > > > > others know that review job has been done. > > > > > > > > WDYT ? > > > > > > > > Gil > > > > > > > > > > > > On 26/01/23 07:48, Jacques Le Roux wrote: > > > > > Hi Daniel, > > > > > > > > > > In "Files changed" tab*, when you select a file, the "Review changes" > > > > > button allows you to comment, approve or request changes on this file. > > > > > I guess "approve" is what you are looking for? > > > > > > > > > > * https://github.com/apache/ofbiz-framework/pull/517/files > > > > > > > > > > Le 26/01/2023 à 17:26, Daniel Watford a écrit : > > > > > > Does anyone know of a way in a GitHub PR that a reviewer can mark an > > > > > > individual file as reviewed-and-passed so that other reviewers can > > > > > > skip > > > > > > that file?
signature.asc
Description: PGP signature
