[
https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553580
]
Jacopo Cappellato commented on OFBIZ-1453:
------------------------------------------
Bilgin,
I did a quick review of your code (no tests) and it seems very good to me; I'd
love to get feedback from others too; in the meantime, here are some misc
comments:
1) you should create the new product and product assoc by colling the proper
services (not directly storing the records in the db)
2) in general, I like the way you have implemented it; it is quite flexible:
for example, in the future, we could implement the ability (with a flag
somewhere) to define if new productId should be created (to represent the
configuration) or not; if we don't want the new product id then we can simply
add a condition in the getAggregatedProductId to always return the product id
of the original AGGREGATE product and everything should work as expected (of
course there will be places where the configuration is not available, for
example inventory).
I'll add more comments in the next few days
Jacopo
> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated.patch, aggregated_full_for_review.patch,
> aggregated_full_for_review.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
