[ 
https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606780#action_12606780
 ] 

Jacopo Cappellato commented on OFBIZ-1842:
------------------------------------------

Thanks Christian,

I too am running it without issues so far.
The only part I don't feel super comfortable with is the changes I did to the 
GeronimoContainer.java file.
Unfortunately I don't know much about the old TransactionContextManager class 
and I am not really sure if the old lines:

this.geronimoTcm = new TransactionContextManager();
this.geronimoTcm.getTransactionManager();

are equivalent to the new one:

new GeronimoTransactionManager();

A quick code review from you and others would really help.

Jacopo



> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of 
> the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager 
> version 2.1.1
> I am testing it now in my box (no problems until now) but I would really 
> appreciate your review (especially to the GeronimoContainer.java class file) 
> because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to