[ 
https://issues.apache.org/jira/browse/OFBIZ-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606901#action_12606901
 ] 

David E. Jones commented on OFBIZ-1842:
---------------------------------------

Jacopo,

I only have limited experience with Geronimo and its transaction manager, but 
I'd say if the new way of just constructing the object directly is working, 
then let's go for it.

In the old case we created a new object before getting the transaction manager 
from it, so I can imagine that this is the way it was intended to be done and 
it is just a clean up of the API.

-David

> Upgrade to Geronimo TXManager 2.1.1
> -----------------------------------
>
>                 Key: OFBIZ-1842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: geronimotx.patch
>
>
> Please review the attached patch that will replace the existing version of 
> the Geronimo TX Manager and Jencks jars with the new Geronimo TX Manager 
> version 2.1.1
> I am testing it now in my box (no problems until now) but I would really 
> appreciate your review (especially to the GeronimoContainer.java class file) 
> because I modified some code that I don't know very well.
> Thanks,
> Jacopo
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to