[
https://issues.apache.org/jira/browse/OFBIZ-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646124#action_12646124
]
David E. Jones commented on OFBIZ-2018:
---------------------------------------
This is one case where it might be good to have less consistency, or in other
words to have these fields be more distinguished.
What I mean is that in a way having a field named "currencyUomId" is only a
little better than having a field named "uomId". In either case you don't know
what the Uom is describing, ie what field it relates to.
Fields that relate to other fields but are not similarly named is something we
could consider an "anti-pattern" and it would be nice to change these to be
more specific than less.
> put currency currencyUomId field in the primary key of the RateType entity
> and add percentage field in the partyRate entity
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2018
> URL: https://issues.apache.org/jira/browse/OFBIZ-2018
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/projectmgr, workeffort
> Affects Versions: SVN trunk
> Environment: any
> Reporter: Hans Bakker
> Assignee: Hans Bakker
> Priority: Minor
> Fix For: SVN trunk
>
>
> Proposed are 2 changes realting to a rate:
> 1. move the currencyUomId field in the primary key of the Ratetype table and
> change the reference to the PartyRate including the rateType and
> currencyUomId. This allows to specify a rateType in different currencies.
> 2. Add a percentage field to the partyRate entity to charge only a percentage
> of the actual time spend on the task. We have many employees in training and
> we want only a percentage of the time to be charged on the invoice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
