[ 
https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659944#action_12659944
 ] 

Bruno Busco commented on OFBIZ-2106:
------------------------------------

Adrian,
I cannot see the problem.

Right now we have and maintain two themes, one for ecommerce and one
for backoffice. Each theme is composed by an header, a footer, several
stylesheets and other related files.

These files are distributed into ofbiz folders and now, with the
introduction of VisualThemes, each set of file has been grouped and
labeled with a VisualTheme.

I think that we will never add more themes into the SVN (my
vt_multiflex.zip file is absolutely not intended to be commited).
So we should always take care, into the SVN, of only two themes as is
has been unitl now (no one more file).

In the theme gallery in Confluence there will be hopefully more themes
available to be downloaded and installed locally. The Theme manager
into OFBiz will let the user to have many of them to choose from.

In this case the new visualThemeTypeId field could be handy in a way
that only applicable themes out of what has been installed are offered
to the user to choose from.

If OFBIZ-1119 will go further and we will have both ecommerce and
backoffice to share the same stylesheets AND header AND footer (which
I really do not think be possible) we could then do not use the
visualTheme classification and use just one class.

> Visual Themes for Ecommerce
> ---------------------------
>
>                 Key: OFBIZ-2106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2106
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: bin.zip, BrowseCategoryCSS.patch, 
> EcommerceVisualTheme.patch, EcommerceVisualTheme.patch, screenshot.JPG, 
> vt_multiflex.zip
>
>
> Hi,
> in the attached patch a simple implementation of selectable visual themes for 
> the ecommerce application.
> I have added the "visualThemeId" to the ProductStore entity. The user can 
> select one of the available themes in the EditProductStore screen.
> I have defined the actual ecommerce theme as the default theme that is 
> "EC_DEFAULT".
> I have followed for the ecommerce main-decorator screen a pattern similar to 
> what done for the back-end.
> One thing that we could think to do (but I would like to hear someone about) 
> is to add a "typeId" field or similar to the VisualTheme entity that could be 
> used to distinguish between the themes for the back-end and for the ecommerce.
> Right now it is possible to select all of the available themes for bost 
> application and this results in a mess if, for example, a theme for ecommerce 
> is selected for the back-end and viceversa.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to