Yes, this is a good point. I agree but I then suggest to have the svninfo.ftl not committed. It will be created by a "ant build" command (with "unknown") and/or by the "ant svinfo" (with the correct version).
If this is ok I will proceed to update the patch. -Bruno 2009/2/3 Jacques Le Roux (JIRA) <j...@apache.org> > > [ > https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670010#action_12670010] > > Jacques Le Roux commented on OFBIZ-1700: > ---------------------------------------- > > Hi Bruno, > > It's great, but I see a problem with this approach : if for a reason or > another svninfo is not run, then svninfo.ftl will contain a wrong release > number. > I suggest that > * we put "unknown" in place of ??? by default (more clear) > * we put back "unknown" in svninfo.ftl when "build", or a "run-" target is > run (maybe did not look into details) > > My 2cts > > > To show Current Revision number of OFBiz on its home site that will > facilate in testing and comparing things with a local copy of OFBiz > > > ---------------------------------------------------------------------------------------------------------------------------------------- > > > > Key: OFBIZ-1700 > > URL: https://issues.apache.org/jira/browse/OFBIZ-1700 > > Project: OFBiz > > Issue Type: New Feature > > Reporter: Vikas Mayur > > Assignee: Jacques Le Roux > > Attachments: about_app.zip, about_ss.JPG, screenshot1.png, > screenshot2.png, svninfo.patch, svninfo.patch, svninfo_ss1.gif, > svninfo_ss2.gif > > > > > > We can put OFBiz Revision Number : > > 1) along with the Trunk and Release labels under Demo Sites section in > OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1 > > 2) In the footer file. Refer to screenshot2 & a discussion started by > Jacques at > http://www.nabble.com/Mention-of-version---in-release-to13078575.html > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
