-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Submit a patch in the jira
madppiper sent the following on 3/25/2009 6:30 AM:
> Hey,
>
> I would argue for the following slight modifications in FtpServices.java and
> Framework/Common/servicedef/services.xml:
>
> Services.xml:
>
> Replace:
> <service name="ftpInterface" engine="interface" location="" invoke="">
> <attribute name="hostname" type="String" mode="IN"
> optional="false"/>
> <attribute name="username" type="String" mode="IN"
> optional="false"/>
> <attribute name="password" type="String" mode="IN"
> optional="false"/>
> <attribute name="localFilename" type="String" mode="IN"
> optional="false"/>
> <attribute name="remoteFilename" type="String" mode="IN"
> optional="false"/>
> <attribute name="binaryTransfer" type="Boolean" mode="IN"
> optional="true"/>
> <attribute name="passiveMode" type="Boolean" mode="IN"
> optional="true"/>
> </service>
>
> with
>
> <service name="ftpInterface" engine="interface" location="" invoke="">
> <attribute name="hostname" type="String" mode="IN"
> optional="false"/>
> <attribute name="username" type="String" mode="IN"
> optional="false"/>
> <attribute name="password" type="String" mode="IN"
> optional="false"/>
> <attribute name="localFilename" type="String" mode="IN"
> optional="false"/>
> <attribute name="remoteFilename" type="String" mode="IN"
> optional="false"/>
> <attribute name="binaryTransfer" type="Boolean" mode="IN"
> optional="true"/>
> <attribute name="port" type="String" mode="IN" optional="true"/>
> <attribute name="passiveMode" type="Boolean" mode="IN"
> optional="true"/>
> </service>
>
>
>
> and in FtpServices.java:
>
> replace line 65
>
> ftp.connect((String) context.get("hostname"));
>
> with
>
> if(Integer.parseInt((String) context.get("port"))!=0 ||
> context.get("port")!= null){
> ftp.connect((String)
> context.get("hostname"),Integer.parseInt((String) context.get("port")));
> }else{
> ftp.connect((String) context.get("hostname"));
> }
>
>
>
> This allows the specification of a port if needed...
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFJyl9hrP3NbaWWqE4RAk3QAKC6/p+gp3D9Yqwo09gmePUmh1F3fgCgyKYB
xJkzqw3+jFoptze88Uh7HkU=
=SheT
-----END PGP SIGNATURE-----
