Hey, I don't have permission to create a new issue yet, so I guess someone would have to either hook me up with that or apply the improvements himself :(
------------------------------------------------------------------------------------------------------- Paul M. Piper - IT & E-Commerce - Mutschler Ventures AG Pfingstweidstrasse 60 8005 Zürich Schweiz Tel.: +41 - (0) - 44 268 18 - 58 Fax : +41 - (0) - 44 268 18 - 66 Mobil: +41 - (0) - 77 460 38 58 Skype: paul.piper E-Mail: paul.pi...@mutschler.ch XING: https://www.xing.com/profile/Paul_Piper ------------------------------------------------------------------------------------------------------- Der Inhalt dieser E-Mail ist ausschließlich fuer den bezeichneten Adressaten bestimmt. Wenn Sie nicht der vorgesehene Adressat dieser E-Mail oder dessen Vertreter sein sollten, so beachten Sie bitte, dass jede Form der Kenntnisnahme, Veroeffentlichung, Vervielfaeltigung oder Weitergabe des Inhalts dieser E-Mail unzulaessig ist. Wir bitten Sie, sich in diesem Fall mit dem Absender der E-Mail in Verbindung zu setzen. The information contained in this email is intended solely for the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any form of disclosure, reproduction, distribution or any action taken or refrained from in reliance on it is prohibited and may be unlawful. Please notify the sender immediately. -----Ursprüngliche Nachricht----- Von: BJ Freeman [mailto:bjf...@free-man.net] Gesendet: Mittwoch, 25. März 2009 17:44 An: dev@ofbiz.apache.org Betreff: Re: A tiny update in ftpservices -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Submit a patch in the jira madppiper sent the following on 3/25/2009 6:30 AM: > Hey, > > I would argue for the following slight modifications in FtpServices.java and > Framework/Common/servicedef/services.xml: > > Services.xml: > > Replace: > <service name="ftpInterface" engine="interface" location="" invoke=""> > <attribute name="hostname" type="String" mode="IN" > optional="false"/> > <attribute name="username" type="String" mode="IN" > optional="false"/> > <attribute name="password" type="String" mode="IN" > optional="false"/> > <attribute name="localFilename" type="String" mode="IN" > optional="false"/> > <attribute name="remoteFilename" type="String" mode="IN" > optional="false"/> > <attribute name="binaryTransfer" type="Boolean" mode="IN" > optional="true"/> > <attribute name="passiveMode" type="Boolean" mode="IN" > optional="true"/> > </service> > > with > > <service name="ftpInterface" engine="interface" location="" invoke=""> > <attribute name="hostname" type="String" mode="IN" > optional="false"/> > <attribute name="username" type="String" mode="IN" > optional="false"/> > <attribute name="password" type="String" mode="IN" > optional="false"/> > <attribute name="localFilename" type="String" mode="IN" > optional="false"/> > <attribute name="remoteFilename" type="String" mode="IN" > optional="false"/> > <attribute name="binaryTransfer" type="Boolean" mode="IN" > optional="true"/> > <attribute name="port" type="String" mode="IN" optional="true"/> > <attribute name="passiveMode" type="Boolean" mode="IN" > optional="true"/> > </service> > > > > and in FtpServices.java: > > replace line 65 > > ftp.connect((String) context.get("hostname")); > > with > > if(Integer.parseInt((String) context.get("port"))!=0 || > context.get("port")!= null){ > ftp.connect((String) > context.get("hostname"),Integer.parseInt((String) context.get("port"))); > }else{ > ftp.connect((String) context.get("hostname")); > } > > > > This allows the specification of a port if needed... > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJyl9hrP3NbaWWqE4RAk3QAKC6/p+gp3D9Yqwo09gmePUmh1F3fgCgyKYB xJkzqw3+jFoptze88Uh7HkU= =SheT -----END PGP SIGNATURE-----
