I added  patch for attributes to jira ticket : 
https://issues.apache.org/jira/browse/OFBIZ-2889
Please review when you get a chance.

I added prepend option to mirror append option earlier. This would allow child 
to do somethings and then hand over to parent actions.
                      <xs:enumeration value="prepend">
                        <xs:annotation>
                          <xs:documentation>prepend form actions to list of 
parent form actions</xs:documentation>
                        </xs:annotation>


'super' element is certainly powerful. One can also call super multiple times 
and all the nice goodies. I think power user and non power user needs need not 
be exlusive. One could develop 'super' element and do custom calling in leaf 
form. Default 'override' strategy would not come in the way. To me it is still 
power user and so did not build it up myself. 


Harmeet
----- Original Message -----
From: "Adrian Crum" <adri...@hlmksw.com>
To: dev@ofbiz.apache.org
Sent: Tuesday, September 1, 2009 3:38:46 PM GMT -05:00 US/Canada Eastern
Subject: Re: action list in form inheritance

One of the nice things about an element is you can place it anywhere in 
the child form's actions. In other words, run some actions, call parent 
actions, run some more actions.

-Adrian

David E Jones wrote:
> 
> I'll admit that this is fairly subjective, and one can guess at what 
> most people would find intuitive, but as for my subjectivity it says 
> that additional extends-* attributes would be better. On the other hand, 
> there are a lot of attributes on the form elements, but I guess that's 
> another topic really...
> 
> -David
> 
> 
> On Sep 1, 2009, at 11:53 AM, Harmeet Bedi wrote:
> 
>> You have to look at form attributes to see how to extend. So seeing 
>> related extends attributes - extends-actions and extends-row-actions 
>> may help a person understand potential options with extend.
>>
>> I feel goal should be to help new users become more efficient and make 
>> behavior assumptions more visible. I feel 'super' element may help 
>> power users but does not reduce curve.
>>
>> Harmeet
>>
>>
>> ----- Original Message -----
>> From: "Bob Morley" <rmor...@emforium.com>
>> To: dev@ofbiz.apache.org
>> Sent: Tuesday, September 1, 2009 10:03:01 AM GMT -05:00 US/Canada Eastern
>> Subject: Re: action list in form inheritance
>>
>>
>> I really like the super idea.  Here is a proposal:
>>
>> - add support for the "super" element (or some reasonable name) to both
>> actions and row-actions
>> - add a new attribute "override" to the actions and row-actions.  Its 
>> only
>> value would be "true" (it would be nice to have attribute minimization 
>> here
>> so we could have no attribute value)
>> - if the "override" attribute is not included on an actions or 
>> row-actions
>> block that has a parent, a warning should be produced to the developer
>> informing them they should add that attribute
>>
>> Reasons:
>> - most flexibility
>> - most visibility
>> - does no harm (unless you count warning messages :) )
>>
>> The thing I do not like about the current approach is that you are 
>> going to
>> bury more attributes on an already bloated form.  The new attributes are
>> going to have defaults (for backwards compat) so no one is going to 
>> set them
>> anyway.  These attributes, if used, should be on the rows and row-actions
>> elements IMHO (but I prefer the proposal above).
>>
>>
>> David E Jones-4 wrote:
>>>
>>>
>>> Yes, that would be another way... ie don't call parent form actions
>>> unless it is explicitly specific as opposed to calling it unless
>>> something says not to call it.
>>>
>>> -David
>>>
>>>
>>> On Aug 31, 2009, at 5:23 PM, Adrian Crum wrote:
>>>
>>>> Maybe what the actions section needs is an element that would
>>>> duplicate super().
>>>>
>>>> -Adrian
>>>>
>>>
>>
>> -- 
>> View this message in context: 
>> http://www.nabble.com/action-list-in-form-inheritance-tp25217949p25240756.html
>>  
>>
>> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>>
> 
> 

Reply via email to