Re: svn commit: r810807 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/screen/MacroScreenRenderer.java templates/htmlScreenMacroLibrary.ftl

[Scott Gray]

Why not just escape the quotation mark with \"

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 5/09/2009, at 6:40 AM, Malin Nicolas wrote:

Jacques Le Roux a écrit :

The idea is to find a separator that will not be found in any string. BTW, that could be also a string and not a sole character, as it's only used internally. I suggested Nicolas to use ¤ (because I never found this character used in a string) but I guess he used µµ because he found a problem with ¤.

Let's Nicolas talk about it...

Yes , try to use jacques proposition but my keyboard layout d'ont have this, so I use µµ for internal separator. When I tested, I have no warning compilation, I strange that µµ not know in UTF-8 encode. Maybe a problem with the patch ? I search.

Nicolas

Jacques

From: "Scott Gray" <scott.g...@hotwaxmedia.com>
FYI, I now get the following warning during compilation:
 [javac15] /Users/lektran/Documents/workspace/amazon/framework/
widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java:676:
warning: unmappable character for encoding UTF-8
 [javac15]         sr.append(menuString.replaceAll("\"", "??"));

Regards
Scott

On 3/09/2009, at 8:22 PM, jler...@apache.org wrote:

Author: jleroux
Date: Thu Sep  3 08:22:49 2009
New Revision: 810807

URL: http://svn.apache.org/viewvc?rev=810807&view=rev
Log:

A patch from Nicolas Malin 'error whan parsing menu with " on screelet header' https://issues.apache.org/jira/browse/ OFBIZ-2873) - OFBIZ-2873

Modified:

  ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl


URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java?rev=810807&r1=810806&r2=810807&view=diff

@@ -673,7 +673,7 @@
       sr.append("\" padded=");
       sr.append(Boolean.toString(padded));
       sr.append(" menuString=\"");

+        sr.append(menuString.replaceAll("\"", "µµ"));
       sr.append("\" showMore=");
       sr.append(Boolean.toString(showMore));
       sr.append(" collapsed=");


URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=810807&r1=810806&r2=810807&view=diff

@@ -94,7 +94,7 @@

ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ screen/ MacroScreenRenderer.java = = = = = = = = = = ==================================================================== --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java (original) +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java Thu Sep 3 08:22:49 2009 - sr.append(menuString.replaceAll("\"", "'"));//FIXME change the " to ' for fix the macro invoke Modified: ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl = = = = = = = = = = ==================================================================== --- ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl (original) +++ ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl Thu Sep 3 08:22:49 2009

&nbsp</a></li>

</#if>
<#if !collapsed>
-${menuString}
+${menuString?replace("µµ","\"")}
</#if>

</#if>

</ul><br class="clear" /></div><div <#if collapsibleAreaId? has_content> id="${collapsibleAreaId}" <#if collapsed> style="display: none;"</#if></#if><#if padded> class="screenlet- body"</#if>>

--
Nicolas MALIN
Consultant
Tél : 06.17.66.40.06
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : 02.48.02.56.12
Site : http://www.librenberry.net/

smime.p7s
Description: S/MIME cryptographic signature