Re: svn commit: r810807 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/screen/MacroScreenRenderer.java templates/htmlScreenMacroLibrary.ftl

[Scott Gray]

I've reopened the issue and attached a patch that takes advantage of FreeMarker's character escaping ability.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 6/09/2009, at 12:41 AM, Jacques Le Roux wrote:

If in Eclipse I swtich encoding to UTF8 (Menu Edit/Set encoding) I get rid of this warning, even using ¤. I don't know yet if this has others implications...

We could also use ¨ or ^ BTW...

At http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5071879

I read

Jacques
From: "Scott Gray" <scott.g...@hotwaxmedia.com>
FYI, I now get the following warning during compilation:
 [javac15] /Users/lektran/Documents/workspace/amazon/framework/
widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java:676:
warning: unmappable character for encoding UTF-8
 [javac15]         sr.append(menuString.replaceAll("\"", "??"));

Regards
Scott

On 3/09/2009, at 8:22 PM, jler...@apache.org wrote:

his is not a bug. It's a source code editor issue. Simply quit using ISO-8859-1 for source code encoding. I can reproduce it with native ISO-8859 characters, but not with UTF-8. In fact, it would be appropriate to document this more clearly in the release notes. Using UTF-8 text editors is the right way to go.

Author: jleroux
Date: Thu Sep  3 08:22:49 2009
New Revision: 810807

URL: http://svn.apache.org/viewvc?rev=810807&view=rev
Log:

A patch from Nicolas Malin 'error whan parsing menu with " on screelet header' https://issues.apache.org/jira/browse/OFBIZ-2873) - OFBIZ-2873

Modified:

  ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl


URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java?rev=810807&r1=810806&r2=810807&view=diff

@@ -673,7 +673,7 @@
       sr.append("\" padded=");
       sr.append(Boolean.toString(padded));
       sr.append(" menuString=\"");

+        sr.append(menuString.replaceAll("\"", "µµ"));
       sr.append("\" showMore=");
       sr.append(Boolean.toString(showMore));
       sr.append(" collapsed=");


URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlScreenMacroLibrary.ftl?rev=810807&r1=810806&r2=810807&view=diff

@@ -94,7 +94,7 @@

ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java = = = = = = = = = ===================================================================== --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java (original) +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/ MacroScreenRenderer.java Thu Sep 3 08:22:49 2009 - sr.append(menuString.replaceAll("\"", "'"));//FIXME change the " to ' for fix the macro invoke Modified: ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl = = = = = = = = = ===================================================================== --- ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl (original) +++ ofbiz/trunk/framework/widget/templates/ htmlScreenMacroLibrary.ftl Thu Sep 3 08:22:49 2009

&nbsp</a></li>

</#if>
<#if !collapsed>
-${menuString}
+${menuString?replace("µµ","\"")}
</#if>

</#if>

</ul><br class="clear" /></div><div <#if collapsibleAreaId? has_content> id="${collapsibleAreaId}" <#if collapsed> style="display: none;"</#if></#if><#if padded> class="screenlet- body"</#if>>

smime.p7s
Description: S/MIME cryptographic signature