Thanks Jacopo! Regards Scott
On 25/11/2009, at 2:33 AM, Jacopo Cappellato wrote:
ok, fixed in rev. 883688 Jacopo On Nov 24, 2009, at 2:04 PM, Jacopo Cappellato wrote:Scott,thank you for the tests and report, I am on it now and will fix it soon. I was confused by the fact that the errors were not logged under the test log files in runtime/logs folder... I will try to investigate this further.Jacopo On Nov 24, 2009, at 11:34 AM, Scott Gray wrote:Sorry Jacopo, it's still failing:[JUNIT] Results for test suite: accountingtests [java] 2009-11-24 10:34:33,958 (main)[JUNIT] Pass: false | # Tests: 16 | # Failed: 14 # Errors: 0 Regards Scott On 24/11/2009, at 11:30 PM, Scott Gray wrote:Thanks Jacopo, your revision is compiling now on buildbot, the suspense is killing me :-)I know about the entity test failing, it shouldn't affect buildbot though because that test only fails after the first run. It's a problem with the test delegator not catching some async service entity operations so som records are left over from previous test runs. I think that is caused by the JobManager being instantiated with a normal delegator during startup so no entity operations performed by it are caught by the test suite delegators. I've got a fix in mind but need to think about it a bit more.Thanks again Scott On 24/11/2009, at 11:11 PM, Jacopo Cappellato wrote:Ok, I have fixed the accounting test that was failing.BTW, there is still this entitytest that is logged as "failure" (I don't think it is related to the work I did on accounting data):<testcase classname="org.ofbiz.entity.test.EntityTestSuite" name="testMakeValue" time="0.189"> <failure message="4 TestingTypes found expected:<4> but was:<13>" type = "junit .framework .AssertionFailedError">junit.framework.AssertionFailedError: 4 TestingTypes found expected:<4> but was:<13> at org .ofbiz .entity.test.EntityTestSuite.testMakeValue(EntityTestSuite.java: 81) at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java: 146) at org .ofbiz.base.container.ContainerLoader.start(ContainerLoader.java: 100)at org.ofbiz.base.start.Start.startStartLoaders(Start.java:271) at org.ofbiz.base.start.Start.startServer(Start.java:321) at org.ofbiz.base.start.Start.start(Start.java:325) at org.ofbiz.base.start.Start.main(Start.java:410) </failure> </testcase> Regards, Jacopo On Nov 24, 2009, at 8:46 AM, Scott Gray wrote:I think a few people were trying to test it out, I just fixed a bug that Jacques introduced this morning :-)Thanks Jacopo, ping me if you need any help, it's only been a couple of days since I was working on those tests.Regards Scott On 24/11/2009, at 8:39 PM, Jacopo Cappellato wrote:On Nov 24, 2009, at 6:13 AM, Scott Gray wrote:I did actually expect the build to fail, Jacopo committed some data changes yesterday that the accounting tests depend on but I'll get them fixed up tonight. After that you're all on your own, you break it you fix it :-)I could try to say that I was just testing the new build notification mechanism :-)Please Scott, don't work on this, I am fixing them now. JacopoRegards Scott HotWax Media http://www.hotwaxmedia.com On 24/11/2009, at 6:32 PM, build...@apache.org wrote:The Buildbot has detected a failed build of ofbiz-trunk on ASF Buildbot.Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/1829 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: isis_ubuntuBuild Reason: forced: by IRC user <gmcdonald> on channel #asftest: testing new config as requested in INFRA-2345Build Source Stamp: HEAD Blamelist: BUILD FAILED: failed compile_1 sincerely, -The Buildbot
smime.p7s
Description: S/MIME cryptographic signature