Re: svn commit: r884308 - /ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java

[Scott Gray]

On 26/11/2009, at 11:58 AM, Jacques Le Roux wrote:

Oops, Sorry


Fixed at r884325

I missed "> 0" when replacing xpdls != null && xpdls.size() > 0 by UtilValidate.isNotEmpty(xpdls)

Thanks Jacques

The reason of all these troubles is that Shark is not compiled anymore, not Workflow (this answer Adam question). Do we really need to keep them in trunk ? We may put them aside but still accessible ?

When raising discussions like this it is always better to go back and read the previous discussions on the same topic and commenting with those in mind. It is really pointless for us to keep rehashing the same issue unless anything has changed since the last time.

Jacques

From: "Scott Gray" <scott.g...@hotwaxmedia.com>

Can a boolean be compared to an integer or did you just break it again?

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 26/11/2009, at 11:29 AM, jler...@apache.org wrote:

Author: jleroux
Date: Wed Nov 25 22:29:21 2009
New Revision: 884308

URL: http://svn.apache.org/viewvc?rev=884308&view=rev
Log:
Complete Scott's fix in r884292 (using initial code in r821643

Modified:



URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java?rev=884308&r1=884307&r2=884308&view=diff

@@ -177,7 +177,7 @@


       List xpdls = this.getXpdlValues(xpdlId, null, false);

       return (UtilValidate.isNotEmpty(xpdls) ? true : false);
   }

ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/ EntityRepositoryMgr.java Modified: ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/ repository/EntityRepositoryMgr.java = = = = = = = = = = ==================================================================== --- ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/ repository/ EntityRepositoryMgr.java (original) +++ ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/ repository/ EntityRepositoryMgr.java Wed Nov 25 22:29:21 2009 public boolean doesXPDLExist(RepositoryTransaction t, String xpdlId) throws RepositoryException { - Debug.log(UtilValidate.isNotEmpty(xpdls) ? true : false, module); + Debug.log("Does XPDL [" + xpdlId + "] Exist - " + xpdls + "(" + (UtilValidate.isNotEmpty(xpdls) > 0 ? true : false) + ")", module);

smime.p7s
Description: S/MIME cryptographic signature