Personnally, I see more harms than benefits as time goes by. I think it's time
for a vote.
If we don't remove it we should at least take care of issues like the one we just crossed with JavaDoc. Actually, I can't see any
other kind of issues, so simply commenting out JavaDoc targets in /shark/build.xml (with a comment about like in
framework/build.xml) would be sufficient in this case.
If we remove it, we could attach an archive of the component at https://issues.apache.org/jira/browse/OFBIZ-552. And as David said
(thanks for the links Scott), we should do the same for the workflow component which is even older...
This is my opinion
Jacques
From: "Adrian Crum" <adrian.c...@yahoo.com>
Thanks for the links Scott.
David makes a good point: If it isn't doing any harm, then just leave it in there - someone might use it. And various people have
tried to use it - with mixed success. I did a Google search, and for the last two years user questions about the Shark component
have been left unanswered.
What bothers me about it as a developer is what happens from time to time when the Shark component needs to be modified in order
to make it compatible with changes in the framework. The rest of the project continues to move forward, and that component just
sits there. When I make changes to it because of some change in the framework, I have no way to test those changes - because I
can't compile it without the required libraries, and even if I could, I have no idea how to use it or test it. I end up crossing
my fingers and hoping I didn't break anything.
So, I have mixed feelings about removing it. I'm undecided.
-Adrian
--- On Wed, 11/25/09, Scott Gray <scott.g...@hotwaxmedia.com> wrote:
From: Scott Gray <scott.g...@hotwaxmedia.com>
Subject: Re: svn commit: r884308 -
/ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java
To: dev@ofbiz.apache.org
Date: Wednesday, November 25, 2009, 4:55 PM
On 26/11/2009, at 1:47 PM, Scott Gray
wrote:
> On 26/11/2009, at 1:37 PM, Adam Heath wrote:
>
>> Adam Heath wrote:
>>> Jacques Le Roux wrote:
>>>> I thought it would be easy to compile
after some changes. But obviously
>>>> nobody has done this for some time.
>>>> It's late here, so I reopened
>>>> https://issues.apache.org/jira/browse/OFBIZ-552 and
uploaded a
>>>> "shark.patch" from my current WIP, if
someone wants to give it a try...
>>>>
>>>> Jacques
>>>
>>> Working on it...
>>
>> I vote to remove it. Latest shark is LGPL,
which isn't compatible.
>
> That has always been the case, we need a better
rationale for removal.
>
> Regards
> Scott
Also here are a couple of previous threads regarding this
topic:
http://markmail.org/thread/jwjh6v7dqeq5z4bn
http://markmail.org/thread/x2cv6m2ikfw7m55g
Regards
Scott
