[
https://issues.apache.org/jira/browse/OFBIZ-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783473#action_12783473
]
Bruno Busco commented on OFBIZ-3274:
------------------------------------
Adrian,
IMO a left bar (or better a left column) should stay on the left even if a
right-to-left language is selected. I did a quick check and I found that in the
mainrtl.css file the #column-container .left is styled to be on the right; I am
not sure to well understand this.
So the answer to your question is that this behaviour will not change from the
actual. The left column content will be contained in a container with the
"left" style.
I am not sure to understand the rest of your comment.
The idea behind this patch is that application provides content to be placed in
sections and the Global decorator put the content into well styled containers
(I know that this is not new but is the decorator logic). You can see that the
leftbar screen in the CommonScreens.xml file has been purged of the container
tag. This has been moved to the Global decorator.
Moving forward to change other applications to use this method I came across
SFA that as <set field="MainColumnStyle" value="leftonly-larger"/>.
Do we really need this "leftonly-larger" style?
I would use only one left column size for all applications or we should have
both?
> Using decorator sections to control the left-bar
> ------------------------------------------------
>
> Key: OFBIZ-3274
> URL: https://issues.apache.org/jira/browse/OFBIZ-3274
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: OFBIZ-3274 DecoratorSectionLayout.patch
>
>
> Hi,
> at the moment, in order to have a screen rendered with or without a left bar,
> the variables "leftbarScreenName", "leftbarScreenLocation" and
> "MainColumnStyle" need to be set to select a screen for the left bar and a
> main column style.
> This must be done in the screen itself or an application decorator.
> With the attached patch, submitted for your review, a new GlobalDecorator
> section named "left-bar" has been added. If a screen must be displayed with a
> left bar this new decorator section needs to be filled with the selected
> content.
> The main column style is defined in the Global decorator. In order to do this
> a new screen condition has been added: "if-empty-decorator-section". This
> condition allows to check if a decorator section has been added content or
> not. (actually it only checks if the decorator section has been defined).
> In the patch I updated all catalog application screens to use this new method.
> If there are no problems with you with this, I will commit in the next days.
> Thank you for sharing your thoughts about.
> -Bruno
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
