[ 
https://issues.apache.org/jira/browse/OFBIZ-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786998#action_12786998
 ] 

Adrian Crum commented on OFBIZ-3274:
------------------------------------

Bruno,

I'm confused. In your initial comment, you said this change could be used in 
the catalog application - so I thought it was needed for some applications, but 
not all applications. Now you are saying all applications will use it.

If the section you are trying to introduce is not used in every screen, then it 
should be kept in a separate decorator - not in the GlobalDecorator.


> Using decorator sections to control the left-bar
> ------------------------------------------------
>
>                 Key: OFBIZ-3274
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3274
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>         Attachments: OFBIZ-3274 DecoratorSectionLayout.patch, OFBIZ-3274 
> DecoratorSectionLayout.patch
>
>
> Hi,
> at the moment, in order to have a screen rendered with or without a left bar, 
> the variables "leftbarScreenName", "leftbarScreenLocation" and 
> "MainColumnStyle" need to be set to select a screen for the left bar and a 
> main column style.
> This must be done in the screen itself or an application decorator.
> With the attached patch, submitted for your review, a new GlobalDecorator 
> section named "left-bar" has been added. If a screen must be displayed with a 
> left bar this new decorator section needs to be filled with the selected 
> content.
> The main column style is defined in the Global decorator. In order to do this 
> a new screen condition has been added: "if-empty-decorator-section". This 
> condition allows to check if a decorator section has been added content or 
> not. (actually it only checks if the decorator section has been defined).
> In the patch I updated all catalog application screens to use this new method.
> If there are no problems with you with this, I will commit in the next days.
> Thank you for sharing your thoughts about.
> -Bruno

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to