[
https://issues.apache.org/jira/browse/OFBIZ-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785619#action_12785619
]
Bilgin Ibryam commented on OFBIZ-3271:
--------------------------------------
Bruno,
I checked your patch and this would be a good addition to the project.
1. I don't see any security issue in storing userPreference recores with
javascript.
2. Do we need to introduce a new patter for the Ids, I mean the capital
letters? I think we should continue to use camelCase but using shorter names
that would fit in userPrefTypeId field, or even better change the field type
from id-ne to id-long-ne in UserPreference entity, where all the ids would fit
w/o any change.
3. Your changes in ModelScreenWidget.java , modify the current implementation
of the screenlets collapsible status.
4. I think it would be better if this feature is automatically handled by the
screenlet widget, w/o requiring any change on the screen definitions. This
way,the feature will be available for all the screenlets. For that purpose I
added the user preference check to ModelScreenWidget and removed the
initiallyCollapsedExdr as it is not needed. Please take a look at it.
Bilgin
> Storing screenlet collapsed/expanded status as user preferences
> ---------------------------------------------------------------
>
> Key: OFBIZ-3271
> URL: https://issues.apache.org/jira/browse/OFBIZ-3271
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: OFBIZ-3271 persistCollapsed.patch
>
>
> Hi,
> actually the screenlet collapsed/expanded status is reset to the initial
> value every time the page is refreshed.
> in the attached patch there is a solution to have the screenlet
> collapsed/expanded status stored as user preferences so that they stay in the
> collapsed or expanded status whenever the user refresh the page or
> logout/loging again.
> I would like a review from you, before committing.
> Thank you,
> Bruno
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
