[ 
https://issues.apache.org/jira/browse/OFBIZ-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786722#action_12786722
 ] 

Bruno Busco commented on OFBIZ-3271:
------------------------------------

Hi Bilgin,
many thanks for your review, hints and contribution.
I have moved forward on this and want to provide a new patch before committing.

1. That's fine.

2. I have followed your hint for not changing the screenlet id but rather 
change the userPrefTypeId field from type="id-ne" to type="id-long-ne" (since 
this change affects the data model I do not commit yet but show the patch 
before)

3., 4.  I have integrated your ModelScreenWidget.patch in the new version of 
the main patch. Many thanks for contributing.

5. I added a new screenlet attribute "store-collapsed". This defaults to true 
and controls whether the screenlet collapsible status should be saved or not.

If there are no issues I will commit.

Many thanks,
Bruno

> Storing screenlet collapsed/expanded status as user preferences
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-3271
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3271
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>            Priority: Minor
>         Attachments: ModelScreenWidget.patch, OFBIZ-3271 
> persistCollapsed.patch, OFBIZ-3271 persistCollapsed.patch
>
>
> Hi,
> actually the screenlet collapsed/expanded status is reset to the initial 
> value every time the page is refreshed.
> in the attached patch there is a solution to have the screenlet 
> collapsed/expanded status stored as user preferences so that they stay in the 
> collapsed or expanded status whenever the user refresh the page or 
> logout/loging again.
> I would like a review from you, before committing.
> Thank you,
> Bruno

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to