--- On Sat, 1/30/10, Adam Heath <doo...@brainfood.com> wrote:
> From: Adam Heath <doo...@brainfood.com>
> Subject: Re: svn commit: r904921 - in 
> /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java 
> util/string/UelUtil.java
> To: dev@ofbiz.apache.org
> Date: Saturday, January 30, 2010, 6:46 PM
> Adrian Crum wrote:
> > The moral of the story is: developers shouldn't be
> allowed to write to the service context Map. If a service
> needs a Map for local storage, then it should create one.
> 
> Maybe the service engine should make the map readonly,
> with
> Collections.unmodifiableMap?

Yes, plus make get() method calls for parameters that are not defined in the 
service definition throw an exception. It should be an error to try to retrieve 
a parameter that is not in the service definition.



      

Reply via email to