On Feb 2, 2010, at 11:53 PM, Adam Heath wrote: > David E Jones wrote: >> On Feb 2, 2010, at 11:07 PM, Adam Heath wrote: >> >>> [email protected] wrote: >>>> Author: hansbak >>>> Date: Wed Feb 3 03:58:13 2010 >>>> New Revision: 905878 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=905878&view=rev >>>> Log: >>>> fix build error reported by buildbot >>> How did you not discover this before you commited it? Did you not do >>> a clean-all/run-install/run-tests? For such a large commit, this kind >>> of error is inexcusable. >> >> Come now Cardinal Heath, some level of forgiveness can surely be found in >> even the coldest of hearts, and do we not all hope that even the most >> depraved and ignorant among us is deserving of some level of empathy? > > Seriously? Really? You are suggesting that renaming a > component(which is essentially what this is), shouldn't do a standard > clean/test run?
That's absolutely ridiculous. I neither said nor implied anything of the sort. Get your head out of... > There were several other things I could have commentted on, code > quality, design, whatever. Those would have been opinions, when you > really got down to it. I didn't. I commented on procedure. Great, so you chose a personal attack over reviewing things that might actually be helpful. If that's the high road I'll stick to the low one. -David > I admit I haven't been perfect with commits. I have even committed > stuff that has failed to compile. I admit I'm not perfect. However, > the probability of that decreases with the size of the commit/change. I was going to stop above, but sorry, this is bull shit and a totally ridiculous idea. In fact, haven't you even caused problems BECAUSE of trying stick to the evidently sanctified approach of splitting your commits into tiny chunks? What's more... do you test after each commit to make sure that interim updates won't be broken? How can you possibly say that this will cause less problems. > This commit that was done should have caused anyone doing it to step > back, and think for a moment, dot the eyes, cross the tees, so to speak. > > I have overlooked lots of things. I try to live by example. You have > all seen me do very small incremental commits. Before those commit > floods occur, do you think I haven't done at least the very basic of > testing? Do you even think I created those commits in that exact same > order? I will do a bunch of work in a bunch of files, and not > actually commit anything 'til it all works. I then branch, and retype > those changes, so that others can follow the change in design, in much > easier to comprehend chunks. I don't suggest everyone go to that level. > > I also don't comment on everything I see that is wrong. Sometimes I > just silently fix issues. > > But this issue is just one of the things that I can't allow to slide. > >> Please, Your Grace, do not cast out a soul for so little. > > This isn't so little. > > If you were intending your email to be humorous, or sarcastic, then > you may have missed the mark a bit. And, as we all know(I hate doing > this, singling him out), this is a repeat problem with Hans. >
