Hans Bakker wrote: > On Wed, 2010-02-03 at 00:21 -0600, Adam Heath wrote: > >>> 2. if you would have the lib file on your disk, the build would not >>> fail. >> Huh? It was not possible for this to succeed. How did it succeed for >> you? In a word, it didn't, because you didn't even try. >> > > so you tell me that i am lying? You are going to far. > if you have a lib dir in the ebay component locally the compile will be > successful.
I never said you lied. But the commit does *not* succeed. If you had a lib folder, then your commit wasn't pristine, and is not what other developers would see. When anyone breaks a commit, so that others can't even run a compile, that is the worst things to occur. Others don't know what you(general you) was trying to do. It would take them a long time to get up to speed, trying to figure out what you were attempting. We all know how we hate interruptions, how much it affects our ability to get something done, and get back up to speed on what we were working on initially. If a little effort is done by the original author at the time, you can then save time for everyone else. Wouldn't we all like to not have these email discussions take place? The solution is simple; everyone needs to be more careful. I take a bit of personal pride when I see I do a flood commit, no one comments on any code issues, buildbot doesn't complain about errors, and no one else does. I actively try to do different ways of breaking stuff I have done, to make certain I have covered all cases. ps: I hate saying this; people assume everyone else is like themselves. You saying that I called you a liar can fall into that category. It shows me more about you. pps: Yes, I am pissed about all this. This was an obvious problem, thet category of which *has* been repeated over and over. This problem was provably wrong. Yet, instead of talking about *that*, people are attacking me. There was nothing wrong with what I did.
