Really amazing Adam,

1. the commit has no functional changes it is a move.
2. if you would have the lib file on your disk, the build would not
fail.
3. the build error was corrected in less than an hour.

Regards,
Hans

On Tue, 2010-02-02 at 23:07 -0600, Adam Heath wrote:
> [email protected] wrote:
> > Author: hansbak
> > Date: Wed Feb  3 03:58:13 2010
> > New Revision: 905878
> > 
> > URL: http://svn.apache.org/viewvc?rev=905878&view=rev
> > Log:
> > fix build error reported by buildbot
> 
> How did you not discover this before you commited it?  Did you not do
> a clean-all/run-install/run-tests?  For such a large commit, this kind
> of error is inexcusable.
> 
> 
> > 
> > Modified:
> >     ofbiz/trunk/specialpurpose/ebay/build.xml
> >     ofbiz/trunk/specialpurpose/ebaystore/ofbiz-component.xml
> > 
> > Modified: ofbiz/trunk/specialpurpose/ebay/build.xml
> > URL: 
> > http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebay/build.xml?rev=905878&r1=905877&r2=905878&view=diff
> > ==============================================================================
> > --- ofbiz/trunk/specialpurpose/ebay/build.xml (original)
> > +++ ofbiz/trunk/specialpurpose/ebay/build.xml Wed Feb  3 03:58:13 2010
> > @@ -29,7 +29,6 @@
> >      <property name="name" value="ofbiz-ebay"/>
> >  
> >      <path id="local.class.path">
> > -           <fileset dir="${lib.dir}" includes="*.jar"/>
> >          <fileset dir="../../framework/base/lib" includes="*.jar"/>
> >          <fileset dir="../../framework/base/lib/commons" includes="*.jar"/>
> >          <fileset dir="../../framework/base/lib/j2eespecs" 
> > includes="*.jar"/>
> > 
> > Modified: ofbiz/trunk/specialpurpose/ebaystore/ofbiz-component.xml
> > URL: 
> > http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebaystore/ofbiz-component.xml?rev=905878&r1=905877&r2=905878&view=diff
> > ==============================================================================
> > --- ofbiz/trunk/specialpurpose/ebaystore/ofbiz-component.xml (original)
> > +++ ofbiz/trunk/specialpurpose/ebaystore/ofbiz-component.xml Wed Feb  3 
> > 03:58:13 2010
> > @@ -23,7 +23,6 @@
> >          
> > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/ofbiz-component.xsd";>
> >      <resource-loader name="main" type="component"/>
> >      <classpath type="dir" location="config"/>
> > -    <classpath type="jar" location="lib/*"/>
> >      <classpath type="jar" location="build/lib/*"/>
> >      
> >     <entity-resource type="model" reader-name="main" loader="main" 
> > location="entitydef/entitymodel.xml"/>
> > 
> > 
> 
-- 
Antwebsystems.com: Quality OFBiz services for competitive rates

Reply via email to