hans...@apache.org wrote:
> Author: hansbak
> Date: Sun Jan 31 03:59:51 2010
> New Revision: 904970
> 
> URL: http://svn.apache.org/viewvc?rev=904970&view=rev
> Log:
> removed framework dependency on the commonext component introduced in 816083 
> and as reported in he mailinglist by Adrian
> 
> Added:
>     
> ofbiz/trunk/applications/commonext/webapp/ofbizsetup/organization/changeOrgPartyId.groovy
>       - copied unchanged from r904004, 
> ofbiz/trunk/applications/commonext/script/changeOrgPartyId.groovy
> Removed:
>     ofbiz/trunk/applications/commonext/script/changeOrgPartyId.groovy
> Modified:
>     ofbiz/trunk/applications/commonext/widget/CommonScreens.xml
>     ofbiz/trunk/framework/common/widget/CommonScreens.xml
>     ofbiz/trunk/themes/bizznesstime/includes/appbar.ftl
>     ofbiz/trunk/themes/bluelight/includes/appbarOpen.ftl
>     ofbiz/trunk/themes/droppingcrumbs/includes/appbarOpen.ftl
>     ofbiz/trunk/themes/flatgrey/includes/appbar.ftl
> 
> Modified: ofbiz/trunk/themes/bizznesstime/includes/appbar.ftl
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/themes/bizznesstime/includes/appbar.ftl?rev=904970&r1=904969&r2=904970&view=diff
> ==============================================================================
> --- ofbiz/trunk/themes/bizznesstime/includes/appbar.ftl (original)
> +++ ofbiz/trunk/themes/bizznesstime/includes/appbar.ftl Sun Jan 31 03:59:51 
> 2010
> @@ -28,7 +28,7 @@
>              <div id="header-nav" class="clearfix" style="display:none">
>                  <ul>
>                  <li><h4>${uiLabelMap.CommonPrimaryApps}</h4></li>
> -                    <#list displayApps as display>
> +            <#list displayApps as display>
>                <#assign thisApp = display.getContextRoot()>
>                <#assign permission = true>
>                <#assign selected = false>

don't mix code changes and formatting changes together.  What if you
had introduced a typo when this line was reformatted.  In some cases,
such a typo might not be noticed right away.  Later, when someone does
notice something wrong, they will start looking thru svn commit
history.  The commit for this change doesn't say anything about fixing
this issue, so this commit might get skipped when trying to find the
cause.


Reply via email to