Ean Schuessler wrote: > Adam Heath wrote: >> If, however, the change is sloppy, trialing/leading spaces, missing >> spaces, typos, random indentation, it tells me that the author >> him(her)self was sloppy, so might also have made actual real mistakes >> in the code. >> > I do want to note here that Adam's opinions do not necessarily reflect > mine. I don't lose any sleep over trailing spaces in comments... don't > care about em. Nope. > > It does seem like Adam is volunteering to write a really detailed and > comprehensive OFBiz repository style guide page for the Wiki. This > document will, of couse, be based on the best practices from other > projects and the result of calm and reasoned discussion between the > community. Is that correct Adam? Are you volunteering? (If not, you > probably owe the community a whopping dose of STFU)
However, you fail to realize that everything in my commit comments are based on either the existing formatting or styles already in the file, or what others have agreed with me on when I have commented in the past. Yes, a document that developers could refer to would be great. However, if people don't read it, we'll be back to this same point. What's occured in this particular situation, in that people who were involved in previous discussions about code quality haven't been following what was agreed to previously. No matter what, if something has been agreed to in the past, but then is not followed, don't be surprised when you get called out on it.
